ngen.cal performs 1 more iterations than it should

[aaraney]

ngen-cal/python/ngen_cal/src/ngen/cal/search.py

Line 132 in 6c62306

for i in range(start_iteration, iterations+1):

ngen-cal/python/ngen_cal/src/ngen/cal/search.py

Line 182 in 6c62306

for i in range(start_iteration, iterations+1):

I believe should be:

    for i in range(start_iteration, iterations):

Issue found by @ajkhattak (thanks 🎉)

[hellkite500]

If asked to run 100 iterations, iteration 0 is established as an initial evaluation iteration and start_iteration becomes 1. If we want to actually run 100 parameter permutations, then we need a range of 1..100, and since python range is non-inclusive on the end of the range, we use +1 to ensure that we get range(1, 101) which gives 100 parameter permutations.

I don't consider this a bug, but it depends on the expected semantics. The code was originally written based on the semantics I described.