-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show the links and add results inspection #33
Comments
Before I further finalize the table and I add the tests, I have some questions @CunliangGeng. You can already see the results table by running the app from this branch.
|
Let me give my 5 cents here:
Thanks for the great work @gcroci2 :-) |
Updated to 0.05
Indeed :)
About the possible columns, what are "Product", "Predicted BGC Class", and "Taxonometry"? Not in general, but I mean within NPLinker code-base. So far I have inserted in the table these columns: GCF ID, # Links, Top 1 Spectrum ID, Average Score. @CunliangGeng
Currently, for each GCF ID with n links, I calculate the average of the Metcalf scores across all n links. I've noticed that LinkGraph objects (from
Questions:
For now, I'm only using GCF -> Spectrum links for the genomics -> metabolomics tab. Does this make sense? |
@gcroci2 regarding the different version of the Metcalf correlation score, this was described here, briefly: the standardised score for each prospective link takes into account the sizes of the GCF and the MF and adjusts the score accordingly, making the scores comparable between links involving strain sets of different sizes as is necessary when, for example, comparing scores for different spectra or MF for a particular GCF. Regarding the different relationship types, I think it makes sense to keep both spectrum and MolecularFamily in, as at the level of MolecularFamily, the strain membership is different than at the level of Spectrum - akin to GCF versus BGC. Thinking of it now, we do not treat the BGCs in the same way as spectra, something we could consider in the future. Happy to explain further in person, as this can get confusing quite quickly.... |
The last part of the genomics -> metabolomics tab consists in showing the links to the metabolomics data and adding the results inspection:
Blocked by #32
The text was updated successfully, but these errors were encountered: