Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement GNPS loading functionality on DatasetLoader layer #107

Closed
Tracked by #147
hechth opened this issue Feb 22, 2023 · 1 comment
Closed
Tracked by #147

Implement GNPS loading functionality on DatasetLoader layer #107

hechth opened this issue Feb 22, 2023 · 1 comment
Assignees
Labels
MET metabolomics related issues

Comments

@hechth
Copy link
Collaborator

hechth commented Feb 22, 2023

The GNPS loading functionality is implemented for all the parts but not on the layer where it could replace the load_dataset function or _load_metabolomics - we have to decide where to put this functionality and implement the proper class(es).

This would mean replacing the load_gnps.py and metabolomics.py files with the GNPSLoader class.

The GNPSLoader should take all the paths as optional arguments so the user can specify them and if they are not there.

The init function basically has 2 options, either take the root to the folder and figure out the paths yourself or take all individual paths loaded from the config and load the data.

@hechth hechth added the MET metabolomics related issues label Feb 22, 2023
@hechth hechth self-assigned this Feb 22, 2023
@CunliangGeng
Copy link
Member

This is solved in a different way in #196.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
MET metabolomics related issues
Projects
None yet
Development

No branches or pull requests

2 participants