Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code review needed for Step 1 and 2 #12

Open
Patg13 opened this issue Aug 4, 2023 · 0 comments
Open

Code review needed for Step 1 and 2 #12

Patg13 opened this issue Aug 4, 2023 · 0 comments
Labels
bug Something isn't working

Comments

@Patg13
Copy link
Collaborator

Patg13 commented Aug 4, 2023

Because of the upgrade to Ubuntu 20.04, the parallel command block is now outside the scope of the main loop, to stop the process in case of skipping, the continue instruction was replaced by a kill command targeted on the BASH_PID (different for each children).

Because of this, the concept of the exit_on_error is not applicable anymore, it must be changed for something more robust and it must also intercept a kill command (ctrl-c for exemple) and destroy all the process children before killing the main script.

@Patg13 Patg13 added the bug Something isn't working label Aug 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant