Tests do not have Hydro feedforward

[josephmckinsey]

There's a TODO hanging around from before.

┌ Error: simulation failed                                                                                                                        |  ETA: 0:03:34
│   exception =          1
│    The value for the system state used in EnergyLimitParameter__HydroEnergyReservoir is not a finite value NaN This is commonly caused by referencing a state value at a time when such decision hasn't been made. Consider reviewing your models' horizon and interval definitions
│    Stacktrace:
│      [1] error(s::String)
│        @ Base ./error.jl:35
│      [2] update_parameter_values!(model::DecisionModel{GenericOpProblem}, key::PowerSimulations.ParameterKey{PowerSimulations.EnergyLimitParameter, HydroEnergyReservoir}, input::PowerSimulations.DatasetContainer{PowerSimulations.InMemoryDataset})
│        @ PowerSimulations ~/.julia/packages/PowerSimulations/XOWBV/src/parameters/update_parameters.jl:434
│      [3] update_parameters!(model::DecisionModel{GenericOpProblem}, decision_states::PowerSimulations.DatasetContainer{PowerSimulations.InMemoryDataset})
│        @ PowerSimulations ~/.julia/packages/PowerSimulations/XOWBV/src/operation/decision_model.jl:470
│      [4] macro expansion
│        @ ~/.julia/packages/PowerSimulations/XOWBV/src/operation/operation_model_interface.jl:364 [inlined]
│      [5] macro expansion
│        @ ~/.julia/packages/TimerOutputs/RsWnF/src/TimerOutput.jl:237 [inlined]
│      [6] update_model!(model::DecisionModel{GenericOpProblem}, source::PowerSimulations.SimulationState, ini_cond_chronology::InterProblemChronology)
│        @ PowerSimulations ~/.julia/packages/PowerSimulations/XOWBV/src/operation/operation_model_interface.jl:363
│      [7] update_model!(model::DecisionModel{GenericOpProblem}, sim::Simulation)
│        @ PowerSimulations ~/.julia/packages/PowerSimulations/XOWBV/src/simulation/simulation.jl:812
│      [8] macro expansion
│        @ ~/.julia/packages/PowerSimulations/XOWBV/src/simulation/simulation.jl:911 [inlined]
│      [9] macro expansion
│        @ ~/.julia/packages/TimerOutputs/RsWnF/src/TimerOutput.jl:237 [inlined]
│     [10] macro expansion
│        @ ~/.julia/packages/PowerSimulations/XOWBV/src/simulation/simulation.jl:910 [inlined]
│     [11] macro expansion
│        @ ~/.julia/packages/TimerOutputs/RsWnF/src/TimerOutput.jl:237 [inlined]
│     [12] _execute!(sim::Simulation; cache_size_mib::Int64, min_cache_flush_size_mib::Int64, exports::Nothing, enable_progress_bar::Bool, disable_timer_outputs::Bool, results_channel::Nothing)
│        @ PowerSimulations ~/.julia/packages/PowerSimulations/XOWBV/src/simulation/simulation.jl:903
│     [13] _execute!
│        @ ~/.julia/packages/PowerSimulations/XOWBV/src/simulation/simulation.jl:822 [inlined]
│     [14] macro expansion
│        @ ~/.julia/packages/PowerSimulations/XOWBV/src/simulation/simulation.jl:998 [inlined]
│     [15] macro expansion
│        @ ~/.julia/packages/TimerOutputs/RsWnF/src/TimerOutput.jl:237 [inlined]
│     [16] (::PowerSimulations.var"#488#492"{Base.Pairs{Symbol, Union{}, Tuple{}, NamedTuple{(), Tuple{}}}, Simulation})(store::PowerSimulations.HdfSimulationStore)
│        @ PowerSimulations ~/.julia/packages/PowerSimulations/XOWBV/src/simulation/simulation.jl:997
│     [17] open_store(func::PowerSimulations.var"#488#492"{Base.Pairs{Symbol, Union{}, Tuple{}, NamedTuple{(), Tuple{}}}, Simulation}, ::Type{PowerSimulations.HdfSimulationStore}, directory::String, mode::String; filename::String)
│        @ PowerSimulations ~/.julia/packages/PowerSimulations/XOWBV/src/simulation/hdf_simulation_store.jl:108
│     [18] open_store
│        @ ~/.julia/packages/PowerSimulations/XOWBV/src/simulation/hdf_simulation_store.jl:98 [inlined]
│     [19] (::PowerSimulations.var"#487#491"{Base.Pairs{Symbol, Union{}, Tuple{}, NamedTuple{(), Tuple{}}}, Simulation, DataType})()
│        @ PowerSimulations ~/.julia/packages/PowerSimulations/XOWBV/src/simulation/simulation.jl:993
│     [20] with_logstate(f::Function, logstate::Any)
│        @ Base.CoreLogging ./logging.jl:514
│     [21] with_logger
│        @ ./logging.jl:626 [inlined]
│     [22] execute!(sim::Simulation; kwargs::Base.Pairs{Symbol, Union{}, Tuple{}, NamedTuple{(), Tuple{}}})
│        @ PowerSimulations ~/.julia/packages/PowerSimulations/XOWBV/src/simulation/simulation.jl:992
│     [23] execute!
│        @ ~/.julia/packages/PowerSimulations/XOWBV/src/simulation/simulation.jl:978 [inlined]
│     [24] _execute_simulation(base_path::String, sim_name::String)
│        @ Main ~/Programming/PowerAnalytics.jl/test/test_data/results_data.jl:177
│     [25] run_test_sim(result_dir::String)
│        @ Main ~/Programming/PowerAnalytics.jl/test/test_data/results_data.jl:74
│     [26] top-level scope
│        @ ~/Programming/PowerAnalytics.jl/test/test_result_sorting.jl:1
│     [27] include
│        @ ./client.jl:478 [inlined]
│     [28] macro expansion
│        @ ~/Programming/PowerAnalytics.jl/test/runtests.jl:65 [inlined]
│     [29] macro expansion
│        @ /Applications/Julia-1.9.app/Contents/Resources/julia/share/julia/stdlib/v1.9/Test/src/Test.jl:1498 [inlined]
│     [30] macro expansion
│        @ ~/Programming/PowerAnalytics.jl/test/runtests.jl:95 [inlined]
│     [31] macro expansion
│        @ ./timing.jl:273 [inlined]
│     [32] (::var"#3#6"{ConsoleLogger})(file_logger::InfrastructureSystems.FileLogger)
│        @ Main ~/Programming/PowerAnalytics.jl/test/runtests.jl:94
│     [33] open_file_logger(func::var"#3#6"{ConsoleLogger}, filename::String, level::Base.CoreLogging.LogLevel, mode::String)
│        @ InfrastructureSystems ~/.julia/packages/InfrastructureSystems/c88O2/src/utils/logging.jl:334
│     [34] open_file_logger(func::Function, filename::String, level::Base.CoreLogging.LogLevel)
│        @ InfrastructureSystems ~/.julia/packages/InfrastructureSystems/c88O2/src/utils/logging.jl:331
│     [35] run_tests()
│        @ Main ~/Programming/PowerAnalytics.jl/test/runtests.jl:87
│     [36] top-level scope
│        @ ~/Programming/PowerAnalytics.jl/test/runtests.jl:107
│     [37] include(fname::String)
│        @ Base.MainInclude ./client.jl:478
│     [38] top-level scope
│        @ none:6
│     [39] eval
│        @ ./boot.jl:370 [inlined]
│     [40] exec_options(opts::Base.JLOptions)
│        @ Base ./client.jl:280
│     [41] _start()
│        @ Base ./client.jl:522
└ @ PowerSimulations ~/.julia/packages/PowerSimulations/XOWBV/src/simulation/simulation.jl:1005

Originally posted by @josephmckinsey in #10 (comment)