Skip to content

Commit

Permalink
Warn if chiller chills when off
Browse files Browse the repository at this point in the history
  • Loading branch information
mjwitte committed Oct 17, 2024
1 parent ec7398a commit 0e0005b
Showing 1 changed file with 40 additions and 1 deletion.
41 changes: 40 additions & 1 deletion src/EnergyPlus/ChillerElectricEIR.cc
Original file line number Diff line number Diff line change
Expand Up @@ -2583,7 +2583,24 @@ void ElectricEIRChillerSpecs::update(EnergyPlusData &state, Real64 const MyLoad,
Real64 ReportingConstant = state.dataHVACGlobal->TimeStepSysSec;

if (MyLoad >= 0 || !RunFlag) { // Chiller not running so pass inlet states to outlet states
// Set node conditions
// if (MyLoad >= 0 || !RunFlag || this->QEvaporator <= 0.0) { // Chiller not running so pass inlet states to outlet states
// if ((MyLoad < 0 && RunFlag) && (this->CondMassFlowRate >= DataBranchAirLoopPlant::MassFlowTolerance ||
// this->EvapMassFlowRate >= DataBranchAirLoopPlant::MassFlowTolerance)) {
// if (!state.dataGlobal->WarmupFlag && !state.dataGlobal->DoingHVACSizingSimulations &&
// state.dataPlnt->PlantLoop(this->CWPlantLoc.loopNum).LoopSide(this->CWPlantLoc.loopSideNum).FlowLock == DataPlant::FlowLock::Locked)
// { ShowWarningError(state, "Chiller off due to this->QEvaporator <= 0.0 rule"); ShowContinueErrorTimeStamp(
// state,
// format("MyLoad={}, RunFlag={}, this->QEvaporator={}, this->QCondenser={}, this->EvapMassFlowRate={},
// this->CondMassFlowRate={}",
// MyLoad,
// RunFlag,
// this->QEvaporator,
// this->QCondenser,
// this->EvapMassFlowRate,
// this->CondMassFlowRate));
// }
// }
// Set node conditions
state.dataLoopNodes->Node(this->EvapOutletNodeNum).Temp = state.dataLoopNodes->Node(this->EvapInletNodeNum).Temp;
state.dataLoopNodes->Node(this->CondOutletNodeNum).Temp = state.dataLoopNodes->Node(this->CondInletNodeNum).Temp;
if (this->CondenserType != DataPlant::CondenserType::WaterCooled) {
Expand Down Expand Up @@ -2680,6 +2697,28 @@ void ElectricEIRChillerSpecs::update(EnergyPlusData &state, Real64 const MyLoad,
this->HeatRecMassFlow = state.dataLoopNodes->Node(this->HeatRecInletNodeNum).MassFlowRate;
}
}
if (((this->EvapMassFlowRate < DataBranchAirLoopPlant::MassFlowTolerance) ||
(this->CondMassFlowRate < DataBranchAirLoopPlant::MassFlowTolerance)) &&
(this->EvapInletTemp != this->EvapOutletTemp)) {
if (!state.dataGlobal->WarmupFlag && !state.dataGlobal->DoingHVACSizingSimulations &&
state.dataPlnt->PlantLoop(this->CWPlantLoc.loopNum).LoopSide(this->CWPlantLoc.loopSideNum).FlowLock == DataPlant::FlowLock::Locked) {
ShowWarningError(state,
format("Chiller should be off, evap flow rate={}, but EvapInletTemp={} is != EvapOutletTemp={}",
this->EvapMassFlowRate,
this->EvapInletTemp,
this->EvapOutletTemp));
ShowContinueErrorTimeStamp(state,
format("MyLoad={}, RunFlag={}, QEvaporator={}, QCondenser={}, EvapMassFlowRate={}, "
"CondMassFlowRate = {}, Power={} ",
MyLoad,
RunFlag,
this->QEvaporator,
this->QCondenser,
this->EvapMassFlowRate,
this->CondMassFlowRate,
this->Power));
}
}
}

bool ElectricEIRChillerSpecs::thermosiphonDisabled(EnergyPlusData &state)
Expand Down

4 comments on commit 0e0005b

@nrel-bot
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

chillerEIRrepairs (mjwitte) - Win64-Windows-10-VisualStudio-16: Tests Failed (0 of 0 tests passed, 0 test warnings)

Build Badge Test Badge

@nrel-bot-2
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

chillerEIRrepairs (mjwitte) - x86_64-Linux-Ubuntu-22.04-gcc-11.4-UnitTestsCoverage-RelWithDebInfo: Tests Failed (0 of 0 tests passed, 0 test warnings)

Build Badge Test Badge Coverage Badge

@nrel-bot-2c
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

chillerEIRrepairs (mjwitte) - x86_64-Linux-Ubuntu-22.04-gcc-11.4-IntegrationCoverage-RelWithDebInfo: Tests Failed (0 of 0 tests passed, 0 test warnings)

Build Badge Test Badge Coverage Badge

@nrel-bot-2b
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

chillerEIRrepairs (mjwitte) - x86_64-Linux-Ubuntu-22.04-gcc-11.4: OK (2916 of 2916 tests passed, 0 test warnings)

Build Badge Test Badge

Please sign in to comment.