From a2aa6b682161893817a35ea6bbca7f74fabed2a9 Mon Sep 17 00:00:00 2001 From: An Pham Date: Mon, 25 Mar 2024 16:38:14 -0600 Subject: [PATCH 1/3] update defaults to match with ResStock, ComStock, URBANopt --- src/inputs.jl | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/inputs.jl b/src/inputs.jl index ce9bb04..9847589 100644 --- a/src/inputs.jl +++ b/src/inputs.jl @@ -59,14 +59,14 @@ Base.@kwdef mutable struct InputsStruct # Parameters heat_pump_configuration::String = "WSHP" # "WSHP" or "WWHP" borehole_depth_ft::Float64 = 400.0 - ghx_header_depth_ft::Float64 = 4.0 + ghx_header_depth_ft::Float64 = 6.6 # old value = 4.0 # ResStock, ComStock, and URBANopt value is 2m = 6.56168 ft borehole_spacing_ft::Float64 = 20.0 - borehole_diameter_inch::Float64 = 5.0 + borehole_diameter_inch::Float64 = 6.0 # old value = 5 inch, ResStock, ComStock, and URBANopt value is 6 inch borehole_spacing_type::String = "rectangular" # "rectangular" or "hexagonal" ghx_pipe_outer_diameter_inch::Float64 = 1.66 ghx_pipe_wall_thickness_inch::Float64 = 0.16 - ghx_pipe_thermal_conductivity_btu_per_hr_ft_f::Float64 = 0.25 - ghx_shank_space_inch::Float64 = 2.5 + ghx_pipe_thermal_conductivity_btu_per_hr_ft_f::Float64 = 0.23 # Old value = 0.25 = 0.43 W/m-K. ReStock, ComStock and URBANopt value is 0.4 W/m-K which is 0.23127039296 BTU/ft-F + ghx_shank_space_inch::Float64 = 1.27 # old value = 2.5, ResStock = 0.0246m = 0.97 inch, ComStock & URBANopt = 0.0323m = 1.27 inch. Goes with ComStock & URBANopt value ground_thermal_conductivity_btu_per_hr_ft_f::Float64 = NaN # Default depends on climate zone ground_mass_density_lb_per_ft3::Float64 = 162.3 ground_specific_heat_btu_per_lb_f::Float64 = 0.211 From 6c6d1ff39bb502c1a2491ecf4a6d287b065f6cf9 Mon Sep 17 00:00:00 2001 From: An Pham Date: Mon, 25 Mar 2024 17:35:36 -0600 Subject: [PATCH 2/3] standardize defaults with ResStock, ComStock & URBANopt --- src/inputs.jl | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/inputs.jl b/src/inputs.jl index 9847589..c2401d2 100644 --- a/src/inputs.jl +++ b/src/inputs.jl @@ -58,7 +58,7 @@ Base.@kwdef mutable struct InputsStruct ##### These are the exact /GhpGhx POST names from the API ##### # Parameters heat_pump_configuration::String = "WSHP" # "WSHP" or "WWHP" - borehole_depth_ft::Float64 = 400.0 + borehole_depth_ft::Float64 = 443.0 # old value = 400, ResStock = 152m, ComStock and URBANopt = 135m = 443 ft ghx_header_depth_ft::Float64 = 6.6 # old value = 4.0 # ResStock, ComStock, and URBANopt value is 2m = 6.56168 ft borehole_spacing_ft::Float64 = 20.0 borehole_diameter_inch::Float64 = 6.0 # old value = 5 inch, ResStock, ComStock, and URBANopt value is 6 inch @@ -70,7 +70,7 @@ Base.@kwdef mutable struct InputsStruct ground_thermal_conductivity_btu_per_hr_ft_f::Float64 = NaN # Default depends on climate zone ground_mass_density_lb_per_ft3::Float64 = 162.3 ground_specific_heat_btu_per_lb_f::Float64 = 0.211 - grout_thermal_conductivity_btu_per_hr_ft_f::Float64 = 1.0 + grout_thermal_conductivity_btu_per_hr_ft_f::Float64 = 0.75 # old value = 1.0, ResStock, ComStock, URBANopt value = 1.3 W/m-K = 0.75 BTU/ft-F ghx_fluid_specific_heat_btu_per_lb_f::Float64 = 1.0 ghx_fluid_mass_density_lb_per_ft3::Float64 = 62.4 ghx_fluid_thermal_conductivity_btu_per_hr_ft_f::Float64 = 0.34 From a81324f23c95e5bcb4cd735520b4f7ceee0664c6 Mon Sep 17 00:00:00 2001 From: An Pham Date: Wed, 10 Apr 2024 13:50:16 -0600 Subject: [PATCH 3/3] removed old values in comments --- src/inputs.jl | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/src/inputs.jl b/src/inputs.jl index c2401d2..ba64d32 100644 --- a/src/inputs.jl +++ b/src/inputs.jl @@ -58,19 +58,19 @@ Base.@kwdef mutable struct InputsStruct ##### These are the exact /GhpGhx POST names from the API ##### # Parameters heat_pump_configuration::String = "WSHP" # "WSHP" or "WWHP" - borehole_depth_ft::Float64 = 443.0 # old value = 400, ResStock = 152m, ComStock and URBANopt = 135m = 443 ft - ghx_header_depth_ft::Float64 = 6.6 # old value = 4.0 # ResStock, ComStock, and URBANopt value is 2m = 6.56168 ft + borehole_depth_ft::Float64 = 443.0 # ResStock = 152m, ComStock and URBANopt = 135m = 443 ft + ghx_header_depth_ft::Float64 = 6.6 # ResStock, ComStock, and URBANopt value is 2m = 6.56168 ft borehole_spacing_ft::Float64 = 20.0 - borehole_diameter_inch::Float64 = 6.0 # old value = 5 inch, ResStock, ComStock, and URBANopt value is 6 inch + borehole_diameter_inch::Float64 = 6.0 # ResStock, ComStock, and URBANopt value is 6 inch borehole_spacing_type::String = "rectangular" # "rectangular" or "hexagonal" ghx_pipe_outer_diameter_inch::Float64 = 1.66 ghx_pipe_wall_thickness_inch::Float64 = 0.16 - ghx_pipe_thermal_conductivity_btu_per_hr_ft_f::Float64 = 0.23 # Old value = 0.25 = 0.43 W/m-K. ReStock, ComStock and URBANopt value is 0.4 W/m-K which is 0.23127039296 BTU/ft-F - ghx_shank_space_inch::Float64 = 1.27 # old value = 2.5, ResStock = 0.0246m = 0.97 inch, ComStock & URBANopt = 0.0323m = 1.27 inch. Goes with ComStock & URBANopt value + ghx_pipe_thermal_conductivity_btu_per_hr_ft_f::Float64 = 0.23 # ReStock, ComStock and URBANopt value is 0.4 W/m-K which is 0.23127039296 BTU/ft-F + ghx_shank_space_inch::Float64 = 1.27 # ResStock = 0.0246m = 0.97 inch, ComStock & URBANopt = 0.0323m = 1.27 inch. Goes with ComStock & URBANopt value ground_thermal_conductivity_btu_per_hr_ft_f::Float64 = NaN # Default depends on climate zone ground_mass_density_lb_per_ft3::Float64 = 162.3 ground_specific_heat_btu_per_lb_f::Float64 = 0.211 - grout_thermal_conductivity_btu_per_hr_ft_f::Float64 = 0.75 # old value = 1.0, ResStock, ComStock, URBANopt value = 1.3 W/m-K = 0.75 BTU/ft-F + grout_thermal_conductivity_btu_per_hr_ft_f::Float64 = 0.75 # ResStock, ComStock, URBANopt value = 1.3 W/m-K = 0.75 BTU/ft-F ghx_fluid_specific_heat_btu_per_lb_f::Float64 = 1.0 ghx_fluid_mass_density_lb_per_ft3::Float64 = 62.4 ghx_fluid_thermal_conductivity_btu_per_hr_ft_f::Float64 = 0.34