Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Versioning #103

Open
tobin-ford opened this issue Aug 1, 2024 · 3 comments
Open

Versioning #103

tobin-ford opened this issue Aug 1, 2024 · 3 comments
Assignees

Comments

@tobin-ford
Copy link
Collaborator

PVLib V0.11.0 Breaking LETID Tests

To Reproduce
install pvlib=0.11.0 and numpy=2.0.0,
python=3.9.19

Expected behavior
test_calc_injection_outdoors fails due to different values in the check (nan at 88 when it should not have been, following values are slightly different. pvlib=0.10.3 and numpy=1.26.4 fix the issue.

Screenshots
#97 (comment) - screenshot here

Desktop (please complete the following information):

  • occurs when verisions above are used during the testing. Locally resolved when reverting to older versions (metioned above)

SciPy 1.14.0 Breaking Tests

To Reproduce
install scipy=1.14.0 and run tests.
python=3.9.19

Expected behavior
many pvdeg tests will fail because the function signature for scipy.integrate.simpson was changed slightly. Reverting to scipy<1.14.0 fixes the issue.

#97 (comment) - more info here

Desktop
Same as above

@tobin-ford
Copy link
Collaborator Author

#105 Fixes this by restricting the versions for numpy, scipy, and pvlib

@tobin-ford
Copy link
Collaborator Author

To unrestrict the package versions we will need to modify the calc_letid_outdoor test. PVLib issues made the result vary slightly and cause the test to fail.

It would be wise to stay up to date on dependencies.

@tobin-ford
Copy link
Collaborator Author

Docs Dependency Restriction

Mistune==2.0.4 was conflicting with nbsphinx when bulding the with sphinx using make html. We should use a newer version. I set it to use Mistune==3.0.0 in pyproject.toml. Not sure what other versions work but I suspect new versions will work as well.

@tobin-ford tobin-ford mentioned this issue Oct 10, 2024
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants