Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Variable names conformity with PV-Terms #52

Open
MDKempe opened this issue Jan 29, 2024 · 2 comments
Open

Variable names conformity with PV-Terms #52

MDKempe opened this issue Jan 29, 2024 · 2 comments
Labels
Clarity for users Things that help the user implement the code more easily.

Comments

@MDKempe
Copy link
Collaborator

MDKempe commented Jan 29, 2024

Do a review of the variable names used to make sure they conform to pv-terms.

https://duramat.github.io/pv-terms/

@MDKempe MDKempe added the Clarity for users Things that help the user implement the code more easily. label Jan 29, 2024
@MDKempe
Copy link
Collaborator Author

MDKempe commented Apr 2, 2024

This is partially fixed by the creation of two functions map_meta and map_weather which can force conformity of data when brought into python. These should be expanded to include more term corrections as they are identified.

@MDKempe
Copy link
Collaborator Author

MDKempe commented Apr 15, 2024

The plan will be to get Aidan to go through and create a table with the terms from PV-terms, PVdeg, and PVLib. Then there will be fourth column with what we think should be the "correct" term. We will try to adopt terms that work with the best Python common practices. Then we will implement them in PVdeg and try to get PV-terms to modify. This will also include the addition of a number of new terms from PVdeg.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Clarity for users Things that help the user implement the code more easily.
Projects
None yet
Development

No branches or pull requests

1 participant