Remove duplicate prm methods #1583
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
identical to air_loop_hvac_multizone_vav_optimization_required? in Standards.AirLoopHVAC.rb
identical to air_loop_hvac_set_vsd_curve_type in Standards.AirLoopHVAC.rb
identical to model_baseline_system_vav_fan_type in ashrae_90_1_prm.Model.rb
The return value is the same throughout the code base, except for an Xcel program override. We can break this out into a method again if other standards require it.
ashrae_90_1_prm_2019 duplicates the method in ashrae_90_1_prm also remove the Xcel and custom argument reference from the base method
returns the same values as boiler_hot_water_find_search_criteria in Standards.BoilerHotWater.rb
duplicate of coil_heating_gas_find_capacity in Standards.CoilHeatingGas.rb
duplicate of boiler_hot_water_standard_minimum_thermal_efficiency in Standards.BoilerHotWater.rb
remove duplicated method model_prm_baseline_system_number in ashrae_90_1_prm_2019 that is already in ashrae_90_1_prm
this is duplicate of cooling_tower_apply_minimum_power_per_flow in Standards.CoolingTower.rb Note the 'fan_type' is defined as 'Propeller or Axial' in Standards.CoolingTower.rb, and 'Axial' in the PRM version. The PRM data should switch to 'Propeller or Axial' to align with 90.1.
duplicate of chiller_electric_eir_standard_minimum_full_load_efficiency in Standards.ChillerElectricEIR.rb. The returns were changed for setting the chiller name and logging. Add calls to get those variables.
Remove duplicate prm method chiller_electric_eir_find_search_criteria which is already defined in Standards.ChillerElectricEIR.rb. The PRM method looks up the compressor type by an additional features property on the chiller object. Adjust the Standards method to check for compressor_type in chiller additional properties before inferring from the chiller name.
duplicate of model_apply_constructions in Standards.Model.rb Pass the wwr arguments in Standards.Model.rb instead of setting them to nil. If this causes issues, then this needs to be a separate method to set wwr building type.
weilixu
reviewed
Sep 1, 2023
| search_criteria['equipment_type'] = 'Open Cooling Tower' | ||
|
|
||
| # Define the criteria to find the fan type | ||
| search_criteria['fan_type'] = 'Axial' |
There was a problem hiding this comment.
I agree this function is largely duplicate with standard.
To remove this function, we should also update the data file to correctly extract the performance.
Once the data file is corrected, the hvac_efficiency test can pass the CI
I made a change and will wait for CI results to merge the PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially addresses #1441.
Notes: 'fan_type' is defined as 'Propeller or Axial' in Standards.CoolingTower.rb, and 'Axial' in the PRM version. The PRM data should switch to 'Propeller or Axial' to align with 90.1. That's a separate commit to author and add to this PR.