Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more fastCCD metadata #29

Open
ambarb opened this issue Dec 18, 2019 · 2 comments
Open

Add more fastCCD metadata #29

ambarb opened this issue Dec 18, 2019 · 2 comments
Assignees

Comments

@ambarb
Copy link
Contributor

ambarb commented Dec 18, 2019

We are missing framestore mode. See reference to EPICS code for ADFastCCD.

XF:23ID1-ES{FCCD}cam1:FrameStr
XF:23ID1-ES{FCCD}cam1:FrameStr_RBV

https://github.com/areaDetector/ADFastCCD/blob/7a01726d0f3889d3c27481018d0c9d7f6f2abcb8/FastCCDApp/Db/FastCCD.template#L245-L257

Do we want to add overscan rows? overscan columns are already present. HOwever, overscan columns looks to use the PV for setting, not the RBV PV. @stuwilkins should this be RBV? All of the code written here was done concurrently with the ADFastCDD development and I think this is one that was missed. Or maybe I do not understand something.

XF:23ID1-ES{FCCD}cam1:OverscanCols
XF:23ID1-ES{FCCD}cam1:OverscanCols_RBV

Do we want to add Row instructions from the FastCCD1 plugin that displays live images so we can use this information to automatically shape the image into something the user will want to see when using FrameStore or not using FrameStore?

XF:23ID1-ES{FCCD}FastCCD1:Rows_RBV
XF:23ID1-ES{FCCD}FastCCD1:RowOffset_RBV
@ambarb
Copy link
Contributor Author

ambarb commented Nov 20, 2020

https://github.com/NSLS-II-CSX/xf23id1_profiles/blob/b4084d6220c5c2d4152b740d9c3b0897f0aabe80/profile_collection/startup/csx1/startup/detectors.py#L86-L116 takes care of these items

Still remaining for skbeam.recip

  • finished detector size (may be hacking because frame store versus non-frame store don't collect different Q-range (PIXELS)

  • pixel size (mm)

  • calibrated center (hacky now, in start document) (PIXELS) - REQUIRES HELPER FUNCTIONS TO NOTIFY

  • sample distance from detector, which is fixed inside of tardis. (mm) - REQUIRES HELPER FUNCTIONS TO NOTIFY

  • roi5 details

  • roi enabled status (or maybe this is in stats)

  • add shape from HDF5 plugin (this is the shape of the saved image)

@ambarb
Copy link
Contributor Author

ambarb commented Nov 20, 2020

For get_fccd_images() still needs to explore if there is enough metadata to fully concatenate final image

@ambarb ambarb self-assigned this Jan 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant