Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Visual mode highlight in light mode makes text hard to read #36

Open
spellman opened this issue May 23, 2023 · 0 comments
Open

Visual mode highlight in light mode makes text hard to read #36

spellman opened this issue May 23, 2023 · 0 comments

Comments

@spellman
Copy link

Thanks for porting this theme! In light mode, the visual mode highlighting makes a lot of the text hard to read. I've attached a screenshot for reference:

  • Left: nvim 0.8 in vimr with doom-one.vim
  • Center: nvim 0.9 in Alacritty with doom-one.nvim
  • Right: Doom Emacs with default light theme (The coloring is more basic, maybe because I haven't set up treesitter in Emacs.)
image

In Emacs, the highlight is a medium gray that leaves the text much easier to read. Could the visual-mode highlight in doom-one.nvim be changed to look like the Emacs version?
spellman added a commit to spellman/dotfiles that referenced this issue May 23, 2023
@spellman
nvim: doom-one theme -> onedark light theme
1a22b29 
If doom-one improves, I would go back to it. It's bright and cheerful.
As is, though, it's too unusable:
* The visual-mode highlight colors makes text hard to read
    * Issued filed: NTBBloodbath/doom-one.nvim#36
* Comments don't have enough contrast.
* TODO comments REALLY don't have enough contrast.
spellman added a commit to spellman/dotfiles that referenced this issue May 24, 2023
@spellman
nvim: doom-one theme -> onedark light theme
c979872 
If doom-one improves, I would go back to it. It's bright and cheerful.
As is, though, it's too unusable:
* The visual-mode highlight colors makes text hard to read
    * Issued filed: NTBBloodbath/doom-one.nvim#36
* Comments don't have enough contrast.
* TODO comments REALLY don't have enough contrast.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@spellman