From a75fd5283ca323d07b54c3840d5b2fe34189f63c Mon Sep 17 00:00:00 2001 From: Thomas Date: Tue, 14 Jan 2025 10:02:16 +0000 Subject: [PATCH 1/2] Add install GSL step to linux jobs The README specifies this needs to be installed but I guess it was installed anyway on older versions of Ubuntu, but 24.04 doesn't seem to have it and GH have upgraded default --- .github/workflows/check-compilation-across-os.yml | 1 + .github/workflows/format-and-test.yml | 3 ++- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/.github/workflows/check-compilation-across-os.yml b/.github/workflows/check-compilation-across-os.yml index 80a33e5..93f405e 100644 --- a/.github/workflows/check-compilation-across-os.yml +++ b/.github/workflows/check-compilation-across-os.yml @@ -11,6 +11,7 @@ jobs: uses: actions/checkout@v4 - name: Build run: | + sudo apt install gsl-bin libgsl-dev mkdir build && cd build/ cmake .. -DBUILD_TESTS=OFF cmake --build . diff --git a/.github/workflows/format-and-test.yml b/.github/workflows/format-and-test.yml index 89d8e2a..811c17f 100644 --- a/.github/workflows/format-and-test.yml +++ b/.github/workflows/format-and-test.yml @@ -22,7 +22,8 @@ jobs: cmake -B build -S . -DBUILD_TESTING=OFF sudo cmake --build build/ --target install cd .. - + + sudo apt install gsl-bin libgsl-dev mkdir build && cd build/ cmake .. cmake --build . From e347a1b12d3dc3bd74b3aa71f41c98d72feef9dd Mon Sep 17 00:00:00 2001 From: Thomas Date: Tue, 14 Jan 2025 10:09:08 +0000 Subject: [PATCH 2/2] Specifically add ubuntu 22.04 to CI Both 20.04 and 22.04 are still in long term support so we should test them both. --- .github/workflows/check-compilation-across-os.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/check-compilation-across-os.yml b/.github/workflows/check-compilation-across-os.yml index 93f405e..1e65693 100644 --- a/.github/workflows/check-compilation-across-os.yml +++ b/.github/workflows/check-compilation-across-os.yml @@ -4,7 +4,7 @@ jobs: Ubuntu-latest: strategy: matrix: - os: [ubuntu-latest, ubuntu-20.04] + os: [ubuntu-latest, ubuntu-20.04, ubuntu-22.04] runs-on: ${{ matrix.os }} steps: - name: Check out repository code