Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relax highline dependency #23

Merged
merged 2 commits into from
Jul 4, 2014
Merged

Conversation

celeduc
Copy link
Contributor

@celeduc celeduc commented Jun 30, 2014

Loosen highline dependency, as the issue has been resolved.

rsutphin added a commit that referenced this pull request Jul 4, 2014
@rsutphin rsutphin merged commit b8b099d into NUBIC:master Jul 4, 2014
@rsutphin
Copy link
Contributor

rsutphin commented Jul 4, 2014

Thanks.

@rsutphin
Copy link
Contributor

rsutphin commented Jul 4, 2014

Unfortunately, I was not careful in my local testing of this. Fortunately, Travis picked up that there are several test failures with the latest version of Highline on JRuby. So I've reverted the effects of this PR in 681392f.

If you'd care to take a look at them, I'd be happy to review a new PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants