Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent implementation with paper #7

Open
Luciennnnnnn opened this issue Sep 10, 2024 · 1 comment
Open

Inconsistent implementation with paper #7

Luciennnnnnn opened this issue Sep 10, 2024 · 1 comment

Comments

@Luciennnnnnn
Copy link

Luciennnnnnn commented Sep 10, 2024

Hi, I notice this codebase leverage p2 weighting strategy, and timestep sampling strategy is also different with the description in paper. Is my understanding right?

@BDeMo
Copy link
Collaborator

BDeMo commented Oct 19, 2024

The branch: master was out-of-date and the p2 weighting strategy (could be the same issue as this one). Our implementation is mainly in branch: experiment, and the actual curves about sampling and weighting are implemented in speed.diffusion.speed.Speed_IDDPM. Both the timestep sampling strategy and p2 weighting strategy are the same as the description in our paper.

Now the master branch (default) is updated, merging branch: experiment, for reading convenience. If you are intereted in, Plz check it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants