-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove _GNUC_VER
and use _CCCL_GCC_VERSION
instead
#2795
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks again, getting all the monorepo to a consistent state is a ton of work.
Much appreciated
/ok to test |
@@ -60,7 +60,7 @@ struct TestFunc | |||
constexpr Atomic a{t}; | |||
assert(a == t); | |||
} | |||
#if !defined(_GNUC_VER) || _GNUC_VER >= 409 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change needs to be synced with #2784, because then it would change to #if !_CCCL_COMPILER_GCC || _CCCL_GCC_VERSION >= 40900
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We limited the scope of #2784, so this should be fine to go
🟨 CI finished in 3h 49m: Pass: 99%/394 | Total: 5d 16h | Avg: 20m 50s | Max: 1h 52m | Hits: 11%/25874
|
Project | |
---|---|
CCCL Infrastructure | |
+/- | libcu++ |
+/- | CUB |
Thrust | |
CUDA Experimental | |
python | |
CCCL C Parallel Library | |
Catch2Helper |
Modifications in project or dependencies?
Project | |
---|---|
CCCL Infrastructure | |
+/- | libcu++ |
+/- | CUB |
+/- | Thrust |
+/- | CUDA Experimental |
+/- | python |
+/- | CCCL C Parallel Library |
+/- | Catch2Helper |
🏃 Runner counts (total jobs: 394)
# | Runner |
---|---|
326 | linux-amd64-cpu16 |
28 | linux-arm64-cpu16 |
25 | linux-amd64-gpu-v100-latest-1 |
15 | windows-amd64-cpu16 |
_GNUC_VER
and use _CCCL_GCC_VERSION
instead_GNUC_VER
and use _CCCL_GCC_VERSION
instead
🟩 CI finished in 5h 24m: Pass: 100%/394 | Total: 5d 16h | Avg: 20m 50s | Max: 1h 52m | Hits: 11%/25874
|
Project | |
---|---|
CCCL Infrastructure | |
+/- | libcu++ |
+/- | CUB |
Thrust | |
CUDA Experimental | |
python | |
CCCL C Parallel Library | |
Catch2Helper |
Modifications in project or dependencies?
Project | |
---|---|
CCCL Infrastructure | |
+/- | libcu++ |
+/- | CUB |
+/- | Thrust |
+/- | CUDA Experimental |
+/- | python |
+/- | CCCL C Parallel Library |
+/- | Catch2Helper |
🏃 Runner counts (total jobs: 394)
# | Runner |
---|---|
326 | linux-amd64-cpu16 |
28 | linux-arm64-cpu16 |
25 | linux-amd64-gpu-v100-latest-1 |
15 | windows-amd64-cpu16 |
_GNUC_VER
and use _CCCL_GCC_VERSION
instead_GNUC_VER
and use _CCCL_GCC_VERSION
instead
/ok to test |
That said, I am wondering whether with the new macros we need that patch at all |
🟨 CI finished in 2h 02m: Pass: 99%/394 | Total: 6d 20h | Avg: 25m 06s | Max: 1h 32m | Hits: 11%/25890
|
Project | |
---|---|
CCCL Infrastructure | |
+/- | libcu++ |
+/- | CUB |
Thrust | |
CUDA Experimental | |
python | |
CCCL C Parallel Library | |
Catch2Helper |
Modifications in project or dependencies?
Project | |
---|---|
CCCL Infrastructure | |
+/- | libcu++ |
+/- | CUB |
+/- | Thrust |
+/- | CUDA Experimental |
+/- | python |
+/- | CCCL C Parallel Library |
+/- | Catch2Helper |
🏃 Runner counts (total jobs: 394)
# | Runner |
---|---|
326 | linux-amd64-cpu16 |
28 | linux-arm64-cpu16 |
25 | linux-amd64-gpu-v100-latest-1 |
15 | windows-amd64-cpu16 |
We don't. The PR #2850 implements the new way of compiler checks and removes |
Description
This PR removes redundant
_GNUC_VER
macro and replaces it with_CCCL_GCC_VERSION
. Also uses_CCCL_GCC_VERSION
in version comparisons instead of__GNUC__
.Checklist