-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[STF] reduce access mode #2830
Merged
Merged
[STF] reduce access mode #2830
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
/ok to test |
caugonnet
commented
Nov 15, 2024
cudax/include/cuda/experimental/__stf/internal/parallel_for_scope.cuh
Outdated
Show resolved
Hide resolved
caugonnet
commented
Nov 20, 2024
/ok to test |
3 similar comments
/ok to test |
/ok to test |
/ok to test |
caugonnet
commented
Nov 21, 2024
cudax/include/cuda/experimental/__stf/internal/parallel_for_scope.cuh
Outdated
Show resolved
Hide resolved
caugonnet
commented
Nov 21, 2024
// Write the block's result to the output array | ||
if (tid == 0) | ||
{ | ||
tuple_set_op<tuple_ops>(redux_buffer[blockIdx.x], per_block_redux_buffer[0].get()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
specialize if only one block...
/ok to test |
8 similar comments
/ok to test |
/ok to test |
/ok to test |
/ok to test |
/ok to test |
/ok to test |
/ok to test |
/ok to test |
🟨 CI finished in 32m 02s: Pass: 88%/54 | Total: 10h 40m | Avg: 11m 51s | Max: 16m 04s | Hits: 90%/123
|
Project | |
---|---|
CCCL Infrastructure | |
libcu++ | |
CUB | |
Thrust | |
+/- | CUDA Experimental |
python | |
CCCL C Parallel Library | |
Catch2Helper |
Modifications in project or dependencies?
Project | |
---|---|
CCCL Infrastructure | |
libcu++ | |
CUB | |
Thrust | |
+/- | CUDA Experimental |
python | |
CCCL C Parallel Library | |
Catch2Helper |
🏃 Runner counts (total jobs: 54)
# | Runner |
---|---|
43 | linux-amd64-cpu16 |
5 | linux-amd64-gpu-v100-latest-1 |
4 | linux-arm64-cpu16 |
2 | windows-amd64-cpu16 |
/ok to test |
🟨 CI finished in 1h 03m: Pass: 90%/54 | Total: 12h 24m | Avg: 13m 47s | Max: 19m 40s | Hits: 90%/246
|
Project | |
---|---|
CCCL Infrastructure | |
libcu++ | |
CUB | |
Thrust | |
+/- | CUDA Experimental |
python | |
CCCL C Parallel Library | |
Catch2Helper |
Modifications in project or dependencies?
Project | |
---|---|
CCCL Infrastructure | |
libcu++ | |
CUB | |
Thrust | |
+/- | CUDA Experimental |
python | |
CCCL C Parallel Library | |
Catch2Helper |
🏃 Runner counts (total jobs: 54)
# | Runner |
---|---|
43 | linux-amd64-cpu16 |
5 | linux-amd64-gpu-v100-latest-1 |
4 | linux-arm64-cpu16 |
2 | windows-amd64-cpu16 |
/ok to test |
caugonnet
commented
Nov 26, 2024
cudax/include/cuda/experimental/__stf/internal/scalar_interface.cuh
Outdated
Show resolved
Hide resolved
caugonnet
commented
Nov 26, 2024
caugonnet
commented
Nov 26, 2024
caugonnet
commented
Nov 26, 2024
cudax/include/cuda/experimental/__stf/internal/parallel_for_scope.cuh
Outdated
Show resolved
Hide resolved
🟩 CI finished in 36m 00s: Pass: 100%/54 | Total: 11h 41m | Avg: 12m 59s | Max: 20m 16s | Hits: 90%/246
|
Project | |
---|---|
CCCL Infrastructure | |
libcu++ | |
CUB | |
Thrust | |
+/- | CUDA Experimental |
python | |
CCCL C Parallel Library | |
Catch2Helper |
Modifications in project or dependencies?
Project | |
---|---|
CCCL Infrastructure | |
libcu++ | |
CUB | |
Thrust | |
+/- | CUDA Experimental |
python | |
CCCL C Parallel Library | |
Catch2Helper |
🏃 Runner counts (total jobs: 54)
# | Runner |
---|---|
43 | linux-amd64-cpu16 |
5 | linux-amd64-gpu-v100-latest-1 |
4 | linux-arm64-cpu16 |
2 | windows-amd64-cpu16 |
andralex
reviewed
Nov 26, 2024
…typed) constructors if they are read only or not. This is something that could be further improved !
d7a65f3
to
a6024ca
Compare
/ok to test |
/ok to test |
🟩 CI finished in 32m 59s: Pass: 100%/26 | Total: 4h 09m | Avg: 9m 36s | Max: 18m 44s | Hits: 91%/312
|
Project | |
---|---|
CCCL Infrastructure | |
libcu++ | |
CUB | |
Thrust | |
+/- | CUDA Experimental |
python | |
CCCL C Parallel Library | |
Catch2Helper |
Modifications in project or dependencies?
Project | |
---|---|
CCCL Infrastructure | |
libcu++ | |
CUB | |
Thrust | |
+/- | CUDA Experimental |
python | |
CCCL C Parallel Library | |
Catch2Helper |
🏃 Runner counts (total jobs: 26)
# | Runner |
---|---|
18 | linux-amd64-cpu16 |
4 | linux-arm64-cpu16 |
2 | windows-amd64-cpu16 |
2 | linux-amd64-gpu-v100-latest-1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Introduce a reduce access mode to make it much easier to write parallel_for kernels which also perform some reductions to a logical data.
Checklist