-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
backport to_underlying
#2853
Merged
Merged
backport to_underlying
#2853
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miscco
reviewed
Nov 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This wont build because in C++11 a constexpr function can only have a single statement. So you would need to adopt the tests to be only constexpr in C++14.
miscco
requested changes
Nov 18, 2024
libcudacxx/test/libcudacxx/std/utilities/utility/utility.underlying/to_underlying.pass.cpp
Outdated
Show resolved
Hide resolved
miscco
reviewed
Nov 18, 2024
libcudacxx/test/libcudacxx/std/utilities/utility/utility.underlying/to_underlying.pass.cpp
Outdated
Show resolved
Hide resolved
…lying/to_underlying.pass.cpp
/ok to test |
/ok to test |
/ok to test |
/ok to test |
🟨 CI finished in 2h 44m: Pass: 97%/394 | Total: 3d 12h | Avg: 12m 56s | Max: 55m 27s | Hits: 84%/25894
|
Project | |
---|---|
CCCL Infrastructure | |
+/- | libcu++ |
CUB | |
Thrust | |
CUDA Experimental | |
python | |
CCCL C Parallel Library | |
+/- | Catch2Helper |
Modifications in project or dependencies?
Project | |
---|---|
CCCL Infrastructure | |
+/- | libcu++ |
+/- | CUB |
+/- | Thrust |
+/- | CUDA Experimental |
+/- | python |
+/- | CCCL C Parallel Library |
+/- | Catch2Helper |
🏃 Runner counts (total jobs: 394)
# | Runner |
---|---|
326 | linux-amd64-cpu16 |
28 | linux-arm64-cpu16 |
25 | linux-amd64-gpu-v100-latest-1 |
15 | windows-amd64-cpu16 |
miscco
approved these changes
Nov 19, 2024
/ok to test |
🟩 CI finished in 2h 03m: Pass: 100%/394 | Total: 2d 06h | Avg: 8m 13s | Max: 1h 04m | Hits: 87%/25894
|
Project | |
---|---|
CCCL Infrastructure | |
+/- | libcu++ |
CUB | |
Thrust | |
CUDA Experimental | |
python | |
CCCL C Parallel Library | |
+/- | Catch2Helper |
Modifications in project or dependencies?
Project | |
---|---|
CCCL Infrastructure | |
+/- | libcu++ |
+/- | CUB |
+/- | Thrust |
+/- | CUDA Experimental |
+/- | python |
+/- | CCCL C Parallel Library |
+/- | Catch2Helper |
🏃 Runner counts (total jobs: 394)
# | Runner |
---|---|
326 | linux-amd64-cpu16 |
28 | linux-arm64-cpu16 |
25 | linux-amd64-gpu-v100-latest-1 |
15 | windows-amd64-cpu16 |
Thanks a lot for making this feature more available 🎉 |
trxcllnt
pushed a commit
to trxcllnt/cccl
that referenced
this pull request
Nov 23, 2024
* backport `to_underlying` to C++11 * disable test on bit field enums for pre gcc 9.3 due to unmuteable warnings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes C++23's
to_underlying
available in older C++ versions (back to C++11).