-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
unify implementation of [[deprecated]]
attribute
#2934
Conversation
/ok to test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for doing the research!
LGTM
Given that we already need to run the full CI matrix, could you also replace all internal uses of the old macros with the new one? |
Which ones do you mean? If you mean use of |
Yeah I meant the different libraries and we should define a common mechanism to suppress the deprecation warning |
/ok to test |
Looks like we need to ensure that |
CMake Warning (dev) at libcudacxx/CMakeLists.txt:43 (include): Policy CMP0148 is not set: The FindPythonInterp and FindPythonLibs modules are removed. Run "cmake --help-policy CMP0148" for policy details. Use the cmake_policy command to set the policy and suppress this warning.
Co-authored-by: Michael Schellenberger Costa <[email protected]>
Co-authored-by: Bernhard Manfred Gruber <[email protected]> Co-authored-by: Eric Niebler <[email protected]> Co-authored-by: Michael Schellenberger Costa <[email protected]>
* make the upper limit on TMP loop unrolling configurable * drop the TMP PP unrolling limit on nvcc and nvhpc whose parsers are slow
Co-authored-by: Michael Schellenberger Costa <[email protected]>
/ok to test |
🟨 CI finished in 2h 07m: Pass: 88%/402 | Total: 8d 03h | Avg: 29m 14s | Max: 1h 21m | Hits: 12%/17285
|
Project | |
---|---|
+/- | CCCL Infrastructure |
+/- | libcu++ |
+/- | CUB |
+/- | Thrust |
CUDA Experimental | |
python | |
CCCL C Parallel Library | |
Catch2Helper |
Modifications in project or dependencies?
Project | |
---|---|
+/- | CCCL Infrastructure |
+/- | libcu++ |
+/- | CUB |
+/- | Thrust |
+/- | CUDA Experimental |
+/- | python |
+/- | CCCL C Parallel Library |
+/- | Catch2Helper |
🏃 Runner counts (total jobs: 402)
# | Runner |
---|---|
327 | linux-amd64-cpu16 |
32 | linux-amd64-gpu-v100-latest-1 |
28 | linux-arm64-cpu16 |
15 | windows-amd64-cpu16 |
/ok to test |
🟩 CI finished in 2h 03m: Pass: 100%/402 | Total: 4d 01h | Avg: 14m 31s | Max: 1h 23m | Hits: 9%/22094
|
Project | |
---|---|
+/- | CCCL Infrastructure |
+/- | libcu++ |
+/- | CUB |
+/- | Thrust |
CUDA Experimental | |
python | |
CCCL C Parallel Library | |
Catch2Helper |
Modifications in project or dependencies?
Project | |
---|---|
+/- | CCCL Infrastructure |
+/- | libcu++ |
+/- | CUB |
+/- | Thrust |
+/- | CUDA Experimental |
+/- | python |
+/- | CCCL C Parallel Library |
+/- | Catch2Helper |
🏃 Runner counts (total jobs: 402)
# | Runner |
---|---|
327 | linux-amd64-cpu16 |
32 | linux-amd64-gpu-v100-latest-1 |
28 | linux-arm64-cpu16 |
15 | windows-amd64-cpu16 |
/ok to check |
/ok to test |
🟩 CI finished in 2h 21m: Pass: 100%/402 | Total: 2d 07h | Avg: 8m 17s | Max: 39m 39s | Hits: 70%/22094
|
Project | |
---|---|
+/- | CCCL Infrastructure |
+/- | libcu++ |
+/- | CUB |
+/- | Thrust |
CUDA Experimental | |
python | |
CCCL C Parallel Library | |
Catch2Helper |
Modifications in project or dependencies?
Project | |
---|---|
+/- | CCCL Infrastructure |
+/- | libcu++ |
+/- | CUB |
+/- | Thrust |
+/- | CUDA Experimental |
+/- | python |
+/- | CCCL C Parallel Library |
+/- | Catch2Helper |
🏃 Runner counts (total jobs: 402)
# | Runner |
---|---|
327 | linux-amd64-cpu16 |
32 | linux-amd64-gpu-v100-latest-1 |
28 | linux-arm64-cpu16 |
15 | windows-amd64-cpu16 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am marking this as blocked for now.
The issue I am seeing is that we need to introduce a new CUB_DEPRECATED_TYPE_ALIAS
macro to keep all compilers happy.
That indicates that we might break users and we need to be really sure about it
This PR moves implementation of
_CCCL_DEPRECATED
and_CCCL_DEPRECATED_BECAUSE
to CCCL.