Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing include #2855

Merged
merged 1 commit into from
Nov 18, 2024
Merged

Add missing include #2855

merged 1 commit into from
Nov 18, 2024

Conversation

bernhardmgruber
Copy link
Contributor

I am hunting an internal bug report, and I am getting desparate. I noticed a missing #include <cuda/std/functional> on my way, so here it is.

We need the include because later in the file we use cuda::std::plus<>:

template <typename AccumT, typename ScanOpT = ::cuda::std::plus<>>
struct DeviceScanPolicy
...

@bernhardmgruber bernhardmgruber marked this pull request as ready for review November 18, 2024 13:44
@bernhardmgruber bernhardmgruber requested review from a team as code owners November 18, 2024 13:44
@bernhardmgruber bernhardmgruber added the cub For all items related to CUB label Nov 18, 2024
@bernhardmgruber bernhardmgruber enabled auto-merge (squash) November 18, 2024 14:01
@github-actions GitHub Actions
Copy link
Contributor

🟩 CI finished in 1h 32m: Pass: 100%/222 | Total: 1d 23h | Avg: 12m 50s | Max: 1h 08m | Hits: 77%/16144

  • 🟩 cub: Pass: 100%/110 | Total: 1d 01h | Avg: 13m 48s | Max: 1h 08m | Hits: 58%/2964 

    🟩 cpu
  🟩 amd64              Pass: 100%/102 | Total:  1d 00h | Avg: 14m 31s | Max:  1h 08m | Hits:  58%/2964  
  🟩 arm64              Pass: 100%/8   | Total: 36m 15s | Avg:  4m 31s | Max:  4m 47s
🟩 ctk
  🟩 11.1               Pass: 100%/15  | Total:  2h 12m | Avg:  8m 48s | Max: 56m 54s | Hits:  58%/741   
  🟩 11.8               Pass: 100%/3   | Total: 16m 49s | Avg:  5m 36s | Max:  5m 56s
  🟩 12.5               Pass: 100%/4   | Total:  4h 22m | Avg:  1h 05m | Max:  1h 08m
  🟩 12.6               Pass: 100%/88  | Total: 18h 27m | Avg: 12m 34s | Max:  1h 05m | Hits:  58%/2223  
🟩 cudacxx
  🟩 ClangCUDA18        Pass: 100%/4   | Total: 16m 46s | Avg:  4m 11s | Max:  4m 27s
  🟩 nvcc11.1           Pass: 100%/15  | Total:  2h 12m | Avg:  8m 48s | Max: 56m 54s | Hits:  58%/741   
  🟩 nvcc11.8           Pass: 100%/3   | Total: 16m 49s | Avg:  5m 36s | Max:  5m 56s
  🟩 nvcc12.5           Pass: 100%/4   | Total:  4h 22m | Avg:  1h 05m | Max:  1h 08m
  🟩 nvcc12.6           Pass: 100%/84  | Total: 18h 10m | Avg: 12m 58s | Max:  1h 05m | Hits:  58%/2223  
🟩 cudacxx_family
  🟩 ClangCUDA          Pass: 100%/4   | Total: 16m 46s | Avg:  4m 11s | Max:  4m 27s
  🟩 nvcc               Pass: 100%/106 | Total:  1d 01h | Avg: 14m 09s | Max:  1h 08m | Hits:  58%/2964  
🟩 cxx
  🟩 Clang9             Pass: 100%/6   | Total:  1h 08m | Avg: 11m 25s | Max: 13m 56s
  🟩 Clang10            Pass: 100%/3   | Total: 39m 15s | Avg: 13m 05s | Max: 13m 35s
  🟩 Clang11            Pass: 100%/4   | Total: 48m 57s | Avg: 12m 14s | Max: 12m 47s
  🟩 Clang12            Pass: 100%/4   | Total: 46m 57s | Avg: 11m 44s | Max: 13m 00s
  🟩 Clang13            Pass: 100%/4   | Total: 49m 10s | Avg: 12m 17s | Max: 13m 47s
  🟩 Clang14            Pass: 100%/4   | Total: 19m 39s | Avg:  4m 54s | Max:  5m 02s
  🟩 Clang15            Pass: 100%/4   | Total: 21m 21s | Avg:  5m 20s | Max:  5m 32s
  🟩 Clang16            Pass: 100%/4   | Total: 20m 13s | Avg:  5m 03s | Max:  5m 19s
  🟩 Clang17            Pass: 100%/4   | Total: 20m 34s | Avg:  5m 08s | Max:  5m 25s
  🟩 Clang18            Pass: 100%/11  | Total:  1h 37m | Avg:  8m 53s | Max: 33m 14s
  🟩 GCC6               Pass: 100%/2   | Total:  8m 42s | Avg:  4m 21s | Max:  4m 32s
  🟩 GCC7               Pass: 100%/6   | Total: 27m 53s | Avg:  4m 38s | Max:  6m 30s
  🟩 GCC8               Pass: 100%/6   | Total: 27m 49s | Avg:  4m 38s | Max:  5m 16s
  🟩 GCC9               Pass: 100%/6   | Total: 27m 11s | Avg:  4m 31s | Max:  5m 10s
  🟩 GCC10              Pass: 100%/4   | Total: 20m 28s | Avg:  5m 07s | Max:  5m 12s
  🟩 GCC11              Pass: 100%/7   | Total:  1h 30m | Avg: 12m 56s | Max: 57m 26s
  🟩 GCC12              Pass: 100%/4   | Total: 22m 36s | Avg:  5m 39s | Max:  5m 51s
  🟩 GCC13              Pass: 100%/16  | Total:  3h 18m | Avg: 12m 23s | Max: 39m 17s
  🟩 Intel2023.2.0      Pass: 100%/3   | Total:  2h 43m | Avg: 54m 34s | Max: 55m 30s
  🟩 MSVC14.16          Pass: 100%/1   | Total: 56m 54s | Avg: 56m 54s | Max: 56m 54s | Hits:  58%/741   
  🟩 MSVC14.29          Pass: 100%/2   | Total:  1h 54m | Avg: 57m 23s | Max: 58m 23s | Hits:  58%/1482  
  🟩 MSVC14.39          Pass: 100%/1   | Total:  1h 05m | Avg:  1h 05m | Max:  1h 05m | Hits:  58%/741   
  🟩 NVHPC24.7          Pass: 100%/4   | Total:  4h 22m | Avg:  1h 05m | Max:  1h 08m
🟩 cxx_family
  🟩 Clang              Pass: 100%/48  | Total:  7h 12m | Avg:  9m 00s | Max: 33m 14s
  🟩 GCC                Pass: 100%/51  | Total:  7h 03m | Avg:  8m 18s | Max: 57m 26s
  🟩 Intel              Pass: 100%/3   | Total:  2h 43m | Avg: 54m 34s | Max: 55m 30s
  🟩 MSVC               Pass: 100%/4   | Total:  3h 56m | Avg: 59m 10s | Max:  1h 05m | Hits:  58%/2964  
  🟩 NVHPC              Pass: 100%/4   | Total:  4h 22m | Avg:  1h 05m | Max:  1h 08m
🟩 gpu
  🟩 v100               Pass: 100%/110 | Total:  1d 01h | Avg: 13m 48s | Max:  1h 08m | Hits:  58%/2964  
🟩 jobs
  🟩 Build              Pass: 100%/102 | Total: 21h 46m | Avg: 12m 48s | Max:  1h 08m | Hits:  58%/2964  
  🟩 DeviceLaunch       Pass: 100%/1   | Total: 18m 37s | Avg: 18m 37s | Max: 18m 37s
  🟩 GraphCapture       Pass: 100%/1   | Total: 18m 44s | Avg: 18m 44s | Max: 18m 44s
  🟩 HostLaunch         Pass: 100%/3   | Total:  1h 22m | Avg: 27m 27s | Max: 33m 14s
  🟩 TestGPU            Pass: 100%/3   | Total:  1h 31m | Avg: 30m 35s | Max: 39m 17s
🟩 sm
  🟩 60;70;80;90        Pass: 100%/3   | Total: 16m 49s | Avg:  5m 36s | Max:  5m 56s
  🟩 90a                Pass: 100%/4   | Total: 15m 52s | Avg:  3m 58s | Max:  4m 16s
🟩 std
  🟩 11                 Pass: 100%/30  | Total:  6h 23m | Avg: 12m 47s | Max:  1h 04m
  🟩 14                 Pass: 100%/29  | Total:  6h 37m | Avg: 13m 42s | Max:  1h 08m | Hits:  58%/1482  
  🟩 17                 Pass: 100%/27  | Total:  5h 43m | Avg: 12m 43s | Max:  1h 05m | Hits:  58%/741   
  🟩 20                 Pass: 100%/24  | Total:  6h 33m | Avg: 16m 23s | Max:  1h 05m | Hits:  58%/741

  • 🟩 thrust: Pass: 100%/109 | Total: 21h 42m | Avg: 11m 57s | Max: 1h 04m | Hits: 81%/13180 

    🟩 cpu
  🟩 amd64              Pass: 100%/101 | Total: 20h 59m | Avg: 12m 28s | Max:  1h 04m | Hits:  81%/13180 
  🟩 arm64              Pass: 100%/8   | Total: 43m 08s | Avg:  5m 23s | Max:  5m 59s
🟩 ctk
  🟩 11.1               Pass: 100%/15  | Total:  2h 14m | Avg:  8m 56s | Max: 58m 42s | Hits:  76%/2636  
  🟩 11.8               Pass: 100%/3   | Total: 17m 21s | Avg:  5m 47s | Max:  6m 20s
  🟩 12.5               Pass: 100%/4   | Total:  3h 45m | Avg: 56m 28s | Max:  1h 04m
  🟩 12.6               Pass: 100%/87  | Total: 15h 25m | Avg: 10m 38s | Max:  1h 03m | Hits:  82%/10544 
🟩 cudacxx
  🟩 ClangCUDA18        Pass: 100%/4   | Total: 21m 19s | Avg:  5m 19s | Max:  5m 48s
  🟩 nvcc11.1           Pass: 100%/15  | Total:  2h 14m | Avg:  8m 56s | Max: 58m 42s | Hits:  76%/2636  
  🟩 nvcc11.8           Pass: 100%/3   | Total: 17m 21s | Avg:  5m 47s | Max:  6m 20s
  🟩 nvcc12.5           Pass: 100%/4   | Total:  3h 45m | Avg: 56m 28s | Max:  1h 04m
  🟩 nvcc12.6           Pass: 100%/83  | Total: 15h 04m | Avg: 10m 53s | Max:  1h 03m | Hits:  82%/10544 
🟩 cudacxx_family
  🟩 ClangCUDA          Pass: 100%/4   | Total: 21m 19s | Avg:  5m 19s | Max:  5m 48s
  🟩 nvcc               Pass: 100%/105 | Total: 21h 21m | Avg: 12m 12s | Max:  1h 04m | Hits:  81%/13180 
🟩 cxx
  🟩 Clang9             Pass: 100%/6   | Total: 56m 36s | Avg:  9m 26s | Max: 10m 24s
  🟩 Clang10            Pass: 100%/3   | Total: 33m 03s | Avg: 11m 01s | Max: 11m 59s
  🟩 Clang11            Pass: 100%/4   | Total:  1h 07m | Avg: 16m 45s | Max: 39m 08s
  🟩 Clang12            Pass: 100%/4   | Total: 37m 18s | Avg:  9m 19s | Max:  9m 34s
  🟩 Clang13            Pass: 100%/4   | Total: 35m 23s | Avg:  8m 50s | Max:  9m 00s
  🟩 Clang14            Pass: 100%/4   | Total: 23m 50s | Avg:  5m 57s | Max:  6m 23s
  🟩 Clang15            Pass: 100%/4   | Total: 23m 51s | Avg:  5m 57s | Max:  6m 32s
  🟩 Clang16            Pass: 100%/4   | Total: 24m 57s | Avg:  6m 14s | Max:  7m 14s
  🟩 Clang17            Pass: 100%/4   | Total: 23m 53s | Avg:  5m 58s | Max:  6m 35s
  🟩 Clang18            Pass: 100%/11  | Total:  1h 10m | Avg:  6m 21s | Max: 13m 08s
  🟩 GCC6               Pass: 100%/2   | Total:  8m 36s | Avg:  4m 18s | Max:  4m 40s
  🟩 GCC7               Pass: 100%/6   | Total: 29m 05s | Avg:  4m 50s | Max:  6m 03s
  🟩 GCC8               Pass: 100%/6   | Total: 30m 34s | Avg:  5m 05s | Max:  5m 36s
  🟩 GCC9               Pass: 100%/6   | Total: 31m 14s | Avg:  5m 12s | Max:  6m 51s
  🟩 GCC10              Pass: 100%/4   | Total: 22m 52s | Avg:  5m 43s | Max:  6m 08s
  🟩 GCC11              Pass: 100%/7   | Total: 40m 11s | Avg:  5m 44s | Max:  6m 20s
  🟩 GCC12              Pass: 100%/4   | Total: 25m 09s | Avg:  6m 17s | Max:  6m 38s
  🟩 GCC13              Pass: 100%/14  | Total:  1h 56m | Avg:  8m 19s | Max: 30m 32s
  🟩 Intel2023.2.0      Pass: 100%/3   | Total:  2h 01m | Avg: 40m 33s | Max: 43m 40s
  🟩 MSVC14.16          Pass: 100%/1   | Total: 58m 42s | Avg: 58m 42s | Max: 58m 42s | Hits:  76%/2636  
  🟩 MSVC14.29          Pass: 100%/2   | Total:  1h 50m | Avg: 55m 23s | Max: 57m 53s | Hits:  76%/5272  
  🟩 MSVC14.39          Pass: 100%/2   | Total:  1h 25m | Avg: 42m 57s | Max:  1h 03m | Hits:  88%/5272  
  🟩 NVHPC24.7          Pass: 100%/4   | Total:  3h 45m | Avg: 56m 28s | Max:  1h 04m
🟩 cxx_family
  🟩 Clang              Pass: 100%/48  | Total:  6h 35m | Avg:  8m 14s | Max: 39m 08s
  🟩 GCC                Pass: 100%/49  | Total:  5h 04m | Avg:  6m 12s | Max: 30m 32s
  🟩 Intel              Pass: 100%/3   | Total:  2h 01m | Avg: 40m 33s | Max: 43m 40s
  🟩 MSVC               Pass: 100%/5   | Total:  4h 15m | Avg: 51m 04s | Max:  1h 03m | Hits:  81%/13180 
  🟩 NVHPC              Pass: 100%/4   | Total:  3h 45m | Avg: 56m 28s | Max:  1h 04m
🟩 gpu
  🟩 v100               Pass: 100%/109 | Total: 21h 42m | Avg: 11m 57s | Max:  1h 04m | Hits:  81%/13180 
🟩 jobs
  🟩 Build              Pass: 100%/102 | Total: 19h 56m | Avg: 11m 43s | Max:  1h 04m | Hits:  76%/10544 
  🟩 TestCPU            Pass: 100%/4   | Total: 47m 49s | Avg: 11m 57s | Max: 22m 39s | Hits:  99%/2636  
  🟩 TestGPU            Pass: 100%/3   | Total: 58m 22s | Avg: 19m 27s | Max: 30m 32s
🟩 sm
  🟩 60;70;80;90        Pass: 100%/3   | Total: 17m 21s | Avg:  5m 47s | Max:  6m 20s
  🟩 90a                Pass: 100%/4   | Total: 19m 48s | Avg:  4m 57s | Max:  5m 31s
🟩 std
  🟩 11                 Pass: 100%/30  | Total:  5h 04m | Avg: 10m 09s | Max: 46m 06s
  🟩 14                 Pass: 100%/29  | Total:  6h 09m | Avg: 12m 44s | Max: 58m 42s | Hits:  76%/5272  
  🟩 17                 Pass: 100%/27  | Total:  5h 29m | Avg: 12m 11s | Max:  1h 04m | Hits:  76%/2636  
  🟩 20                 Pass: 100%/23  | Total:  4h 59m | Avg: 13m 01s | Max:  1h 03m | Hits:  88%/5272

  • 🟩 cccl_c_parallel: Pass: 100%/2 | Total: 11m 06s | Avg: 5m 33s | Max: 9m 08s

     
    🟩 cpu
  🟩 amd64              Pass: 100%/2   | Total: 11m 06s | Avg:  5m 33s | Max:  9m 08s
🟩 ctk
  🟩 12.6               Pass: 100%/2   | Total: 11m 06s | Avg:  5m 33s | Max:  9m 08s
🟩 cudacxx
  🟩 nvcc12.6           Pass: 100%/2   | Total: 11m 06s | Avg:  5m 33s | Max:  9m 08s
🟩 cudacxx_family
  🟩 nvcc               Pass: 100%/2   | Total: 11m 06s | Avg:  5m 33s | Max:  9m 08s
🟩 cxx
  🟩 GCC13              Pass: 100%/2   | Total: 11m 06s | Avg:  5m 33s | Max:  9m 08s
🟩 cxx_family
  🟩 GCC                Pass: 100%/2   | Total: 11m 06s | Avg:  5m 33s | Max:  9m 08s
🟩 gpu
  🟩 v100               Pass: 100%/2   | Total: 11m 06s | Avg:  5m 33s | Max:  9m 08s
🟩 jobs
  🟩 Build              Pass: 100%/1   | Total:  1m 58s | Avg:  1m 58s | Max:  1m 58s
  🟩 Test               Pass: 100%/1   | Total:  9m 08s | Avg:  9m 08s | Max:  9m 08s

  • 🟩 python: Pass: 100%/1 | Total: 18m 07s | Avg: 18m 07s | Max: 18m 07s

     
    🟩 cpu
  🟩 amd64              Pass: 100%/1   | Total: 18m 07s | Avg: 18m 07s | Max: 18m 07s
🟩 ctk
  🟩 12.6               Pass: 100%/1   | Total: 18m 07s | Avg: 18m 07s | Max: 18m 07s
🟩 cudacxx
  🟩 nvcc12.6           Pass: 100%/1   | Total: 18m 07s | Avg: 18m 07s | Max: 18m 07s
🟩 cudacxx_family
  🟩 nvcc               Pass: 100%/1   | Total: 18m 07s | Avg: 18m 07s | Max: 18m 07s
🟩 cxx
  🟩 GCC13              Pass: 100%/1   | Total: 18m 07s | Avg: 18m 07s | Max: 18m 07s
🟩 cxx_family
  🟩 GCC                Pass: 100%/1   | Total: 18m 07s | Avg: 18m 07s | Max: 18m 07s
🟩 gpu
  🟩 v100               Pass: 100%/1   | Total: 18m 07s | Avg: 18m 07s | Max: 18m 07s
🟩 jobs
  🟩 Test               Pass: 100%/1   | Total: 18m 07s | Avg: 18m 07s | Max: 18m 07s

👃 Inspect Changes

Modifications in project?

Project
CCCL Infrastructure
libcu++
+/- CUB
Thrust
CUDA Experimental
python
CCCL C Parallel Library
Catch2Helper

Modifications in project or dependencies?

Project
CCCL Infrastructure
libcu++
+/- CUB
+/- Thrust
CUDA Experimental
+/- python
+/- CCCL C Parallel Library
+/- Catch2Helper

🏃‍ Runner counts (total jobs: 222)
# Runner
184 linux-amd64-cpu16
16 linux-arm64-cpu16
13 linux-amd64-gpu-v100-latest-1
9 windows-amd64-cpu16

@bernhardmgruber bernhardmgruber merged commit 8a33f6b into NVIDIA:main Nov 18, 2024
238 checks passed
@bernhardmgruber bernhardmgruber deleted the nvbug branch November 18, 2024 15:21
trxcllnt pushed a commit to trxcllnt/cccl that referenced this pull request Nov 23, 2024
@bernhardmgruber @trxcllnt
Add potentially missing header (NVIDIA#2855)
03c0603
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miscco miscco miscco approved these changes

@elstehle elstehle Awaiting requested review from elstehle elstehle is a code owner automatically assigned from NVIDIA/cccl-cub-codeowners

Assignees
No one assigned
Labels
cub For all items related to CUB
Projects
CCCL
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bernhardmgruber @miscco