Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor nvbench helper less_t #2905

Merged
merged 1 commit into from
Nov 21, 2024
Merged

Refactor nvbench helper less_t #2905

merged 1 commit into from
Nov 21, 2024

Conversation

bernhardmgruber
Copy link
Contributor

This PR just moves the less_t::operator<complex> specialization as an overload into less_t because we should prefer function overloading over template specialization. See also: https://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#t144-dont-specialize-function-templates

@bernhardmgruber bernhardmgruber added the benchmark Feature related to benchmarking our libraries label Nov 20, 2024
@bernhardmgruber bernhardmgruber marked this pull request as ready for review November 20, 2024 10:08
@bernhardmgruber bernhardmgruber requested review from a team as code owners November 20, 2024 10:08
@github-actions GitHub Actions
Copy link
Contributor

🟩 CI finished in 1h 03m: Pass: 100%/224 | Total: 1d 07h | Avg: 8m 26s | Max: 1h 02m | Hits: 99%/12288

  • 🟩 thrust: Pass: 100%/111 | Total: 12h 35m | Avg: 6m 48s | Max: 37m 10s | Hits: 99%/9260 

    🟩 cmake_options
  🟩 -DTHRUST_DISPATCH_TYPE=Force32bit Pass: 100%/2   | Total: 48m 55s | Avg: 24m 27s | Max: 37m 10s
🟩 cpu
  🟩 amd64              Pass: 100%/103 | Total: 11h 56m | Avg:  6m 57s | Max: 37m 10s | Hits:  99%/9260  
  🟩 arm64              Pass: 100%/8   | Total: 38m 58s | Avg:  4m 52s | Max:  5m 31s
🟩 ctk
  🟩 11.1               Pass: 100%/15  | Total:  1h 19m | Avg:  5m 19s | Max: 18m 05s | Hits:  99%/1852  
  🟩 11.8               Pass: 100%/3   | Total: 16m 50s | Avg:  5m 36s | Max:  5m 54s
  🟩 12.5               Pass: 100%/4   | Total:  1h 03m | Avg: 15m 46s | Max: 16m 35s
  🟩 12.6               Pass: 100%/89  | Total:  9h 55m | Avg:  6m 41s | Max: 37m 10s | Hits:  99%/7408  
🟩 cudacxx
  🟩 ClangCUDA18        Pass: 100%/4   | Total: 20m 04s | Avg:  5m 01s | Max:  5m 19s
  🟩 nvcc11.1           Pass: 100%/15  | Total:  1h 19m | Avg:  5m 19s | Max: 18m 05s | Hits:  99%/1852  
  🟩 nvcc11.8           Pass: 100%/3   | Total: 16m 50s | Avg:  5m 36s | Max:  5m 54s
  🟩 nvcc12.5           Pass: 100%/4   | Total:  1h 03m | Avg: 15m 46s | Max: 16m 35s
  🟩 nvcc12.6           Pass: 100%/85  | Total:  9h 35m | Avg:  6m 46s | Max: 37m 10s | Hits:  99%/7408  
🟩 cudacxx_family
  🟩 ClangCUDA          Pass: 100%/4   | Total: 20m 04s | Avg:  5m 01s | Max:  5m 19s
  🟩 nvcc               Pass: 100%/107 | Total: 12h 15m | Avg:  6m 52s | Max: 37m 10s | Hits:  99%/9260  
🟩 cxx
  🟩 Clang9             Pass: 100%/6   | Total: 32m 31s | Avg:  5m 25s | Max:  6m 52s
  🟩 Clang10            Pass: 100%/3   | Total: 19m 27s | Avg:  6m 29s | Max:  7m 15s
  🟩 Clang11            Pass: 100%/4   | Total: 20m 17s | Avg:  5m 04s | Max:  5m 23s
  🟩 Clang12            Pass: 100%/4   | Total: 20m 12s | Avg:  5m 03s | Max:  5m 24s
  🟩 Clang13            Pass: 100%/4   | Total: 21m 33s | Avg:  5m 23s | Max:  5m 41s
  🟩 Clang14            Pass: 100%/4   | Total: 20m 53s | Avg:  5m 13s | Max:  5m 30s
  🟩 Clang15            Pass: 100%/4   | Total: 20m 18s | Avg:  5m 04s | Max:  5m 26s
  🟩 Clang16            Pass: 100%/4   | Total: 22m 03s | Avg:  5m 30s | Max:  6m 17s
  🟩 Clang17            Pass: 100%/4   | Total: 20m 24s | Avg:  5m 06s | Max:  5m 20s
  🟩 Clang18            Pass: 100%/11  | Total:  1h 04m | Avg:  5m 49s | Max: 12m 44s
  🟩 GCC6               Pass: 100%/2   | Total:  8m 46s | Avg:  4m 23s | Max:  4m 25s
  🟩 GCC7               Pass: 100%/6   | Total: 27m 25s | Avg:  4m 34s | Max:  5m 15s
  🟩 GCC8               Pass: 100%/6   | Total: 29m 44s | Avg:  4m 57s | Max:  6m 11s
  🟩 GCC9               Pass: 100%/6   | Total: 29m 36s | Avg:  4m 56s | Max:  5m 49s
  🟩 GCC10              Pass: 100%/4   | Total: 23m 05s | Avg:  5m 46s | Max:  6m 42s
  🟩 GCC11              Pass: 100%/7   | Total: 39m 01s | Avg:  5m 34s | Max:  6m 05s
  🟩 GCC12              Pass: 100%/4   | Total: 24m 27s | Avg:  6m 06s | Max:  6m 51s
  🟩 GCC13              Pass: 100%/16  | Total:  2h 18m | Avg:  8m 40s | Max: 37m 10s
  🟩 Intel2023.2.0      Pass: 100%/3   | Total: 20m 02s | Avg:  6m 40s | Max:  6m 45s
  🟩 MSVC14.16          Pass: 100%/1   | Total: 18m 05s | Avg: 18m 05s | Max: 18m 05s | Hits:  99%/1852  
  🟩 MSVC14.29          Pass: 100%/2   | Total: 31m 15s | Avg: 15m 37s | Max: 15m 56s | Hits:  99%/3704  
  🟩 MSVC14.39          Pass: 100%/2   | Total: 40m 38s | Avg: 20m 19s | Max: 23m 22s | Hits:  99%/3704  
  🟩 NVHPC24.7          Pass: 100%/4   | Total:  1h 03m | Avg: 15m 46s | Max: 16m 35s
🟩 cxx_family
  🟩 Clang              Pass: 100%/48  | Total:  4h 21m | Avg:  5m 27s | Max: 12m 44s
  🟩 GCC                Pass: 100%/51  | Total:  5h 20m | Avg:  6m 17s | Max: 37m 10s
  🟩 Intel              Pass: 100%/3   | Total: 20m 02s | Avg:  6m 40s | Max:  6m 45s
  🟩 MSVC               Pass: 100%/5   | Total:  1h 29m | Avg: 17m 59s | Max: 23m 22s | Hits:  99%/9260  
  🟩 NVHPC              Pass: 100%/4   | Total:  1h 03m | Avg: 15m 46s | Max: 16m 35s
🟩 gpu
  🟩 v100               Pass: 100%/111 | Total: 12h 35m | Avg:  6m 48s | Max: 37m 10s | Hits:  99%/9260  
🟩 jobs
  🟩 Build              Pass: 100%/103 | Total: 11h 01m | Avg:  6m 25s | Max: 37m 10s | Hits:  99%/7408  
  🟩 TestCPU            Pass: 100%/4   | Total: 45m 38s | Avg: 11m 24s | Max: 23m 22s | Hits:  99%/1852  
  🟩 TestGPU            Pass: 100%/4   | Total: 48m 55s | Avg: 12m 13s | Max: 12m 44s
🟩 sm
  🟩 60;70;80;90        Pass: 100%/3   | Total: 16m 50s | Avg:  5m 36s | Max:  5m 54s
  🟩 90a                Pass: 100%/4   | Total: 19m 00s | Avg:  4m 45s | Max:  5m 11s
🟩 std
  🟩 11                 Pass: 100%/30  | Total:  2h 46m | Avg:  5m 32s | Max: 16m 17s
  🟩 14                 Pass: 100%/29  | Total:  3h 05m | Avg:  6m 23s | Max: 18m 05s | Hits:  99%/3704  
  🟩 17                 Pass: 100%/27  | Total:  2h 50m | Avg:  6m 18s | Max: 15m 56s | Hits:  99%/1852  
  🟩 20                 Pass: 100%/23  | Total:  3h 05m | Avg:  8m 02s | Max: 23m 22s | Hits:  99%/3704

  • 🟩 cub: Pass: 100%/110 | Total: 18h 29m | Avg: 10m 05s | Max: 1h 02m | Hits: 99%/3028 

    🟩 cpu
  🟩 amd64              Pass: 100%/102 | Total: 17h 16m | Avg: 10m 09s | Max:  1h 02m | Hits:  99%/3028  
  🟩 arm64              Pass: 100%/8   | Total:  1h 12m | Avg:  9m 05s | Max:  9m 36s
🟩 ctk
  🟩 11.1               Pass: 100%/15  | Total:  2h 14m | Avg:  8m 56s | Max:  1h 02m | Hits:  99%/757   
  🟩 11.8               Pass: 100%/3   | Total: 31m 38s | Avg: 10m 32s | Max: 10m 52s
  🟩 12.5               Pass: 100%/4   | Total: 39m 45s | Avg:  9m 56s | Max: 10m 05s
  🟩 12.6               Pass: 100%/88  | Total: 15h 03m | Avg: 10m 16s | Max: 33m 55s | Hits:  99%/2271  
🟩 cudacxx
  🟩 ClangCUDA18        Pass: 100%/4   | Total: 18m 16s | Avg:  4m 34s | Max:  5m 10s
  🟩 nvcc11.1           Pass: 100%/15  | Total:  2h 14m | Avg:  8m 56s | Max:  1h 02m | Hits:  99%/757   
  🟩 nvcc11.8           Pass: 100%/3   | Total: 31m 38s | Avg: 10m 32s | Max: 10m 52s
  🟩 nvcc12.5           Pass: 100%/4   | Total: 39m 45s | Avg:  9m 56s | Max: 10m 05s
  🟩 nvcc12.6           Pass: 100%/84  | Total: 14h 45m | Avg: 10m 32s | Max: 33m 55s | Hits:  99%/2271  
🟩 cudacxx_family
  🟩 ClangCUDA          Pass: 100%/4   | Total: 18m 16s | Avg:  4m 34s | Max:  5m 10s
  🟩 nvcc               Pass: 100%/106 | Total: 18h 10m | Avg: 10m 17s | Max:  1h 02m | Hits:  99%/3028  
🟩 cxx
  🟩 Clang9             Pass: 100%/6   | Total: 43m 03s | Avg:  7m 10s | Max:  9m 52s
  🟩 Clang10            Pass: 100%/3   | Total: 30m 01s | Avg: 10m 00s | Max: 10m 45s
  🟩 Clang11            Pass: 100%/4   | Total: 35m 43s | Avg:  8m 55s | Max:  9m 20s
  🟩 Clang12            Pass: 100%/4   | Total: 36m 17s | Avg:  9m 04s | Max:  9m 22s
  🟩 Clang13            Pass: 100%/4   | Total: 35m 54s | Avg:  8m 58s | Max:  9m 25s
  🟩 Clang14            Pass: 100%/4   | Total: 35m 55s | Avg:  8m 58s | Max:  9m 31s
  🟩 Clang15            Pass: 100%/4   | Total: 35m 03s | Avg:  8m 45s | Max:  8m 53s
  🟩 Clang16            Pass: 100%/4   | Total: 35m 45s | Avg:  8m 56s | Max:  9m 23s
  🟩 Clang17            Pass: 100%/4   | Total: 34m 44s | Avg:  8m 41s | Max:  9m 01s
  🟩 Clang18            Pass: 100%/11  | Total:  2h 04m | Avg: 11m 20s | Max: 33m 55s
  🟩 GCC6               Pass: 100%/2   | Total:  8m 29s | Avg:  4m 14s | Max:  4m 26s
  🟩 GCC7               Pass: 100%/6   | Total:  1h 37m | Avg: 16m 14s | Max:  1h 02m
  🟩 GCC8               Pass: 100%/6   | Total: 42m 30s | Avg:  7m 05s | Max: 11m 19s
  🟩 GCC9               Pass: 100%/6   | Total: 40m 44s | Avg:  6m 47s | Max:  9m 50s
  🟩 GCC10              Pass: 100%/4   | Total: 36m 11s | Avg:  9m 02s | Max:  9m 24s
  🟩 GCC11              Pass: 100%/7   | Total:  1h 09m | Avg:  9m 53s | Max: 10m 52s
  🟩 GCC12              Pass: 100%/4   | Total: 36m 29s | Avg:  9m 07s | Max:  9m 42s
  🟩 GCC13              Pass: 100%/16  | Total:  3h 37m | Avg: 13m 36s | Max: 26m 18s
  🟩 Intel2023.2.0      Pass: 100%/3   | Total: 19m 25s | Avg:  6m 28s | Max:  6m 42s
  🟩 MSVC14.16          Pass: 100%/1   | Total: 14m 54s | Avg: 14m 54s | Max: 14m 54s | Hits:  99%/757   
  🟩 MSVC14.29          Pass: 100%/2   | Total: 25m 25s | Avg: 12m 42s | Max: 12m 56s | Hits:  99%/1514  
  🟩 MSVC14.39          Pass: 100%/1   | Total: 13m 40s | Avg: 13m 40s | Max: 13m 40s | Hits:  99%/757   
  🟩 NVHPC24.7          Pass: 100%/4   | Total: 39m 45s | Avg:  9m 56s | Max: 10m 05s
🟩 cxx_family
  🟩 Clang              Pass: 100%/48  | Total:  7h 27m | Avg:  9m 19s | Max: 33m 55s
  🟩 GCC                Pass: 100%/51  | Total:  9h 08m | Avg: 10m 45s | Max:  1h 02m
  🟩 Intel              Pass: 100%/3   | Total: 19m 25s | Avg:  6m 28s | Max:  6m 42s
  🟩 MSVC               Pass: 100%/4   | Total: 53m 59s | Avg: 13m 29s | Max: 14m 54s | Hits:  99%/3028  
  🟩 NVHPC              Pass: 100%/4   | Total: 39m 45s | Avg:  9m 56s | Max: 10m 05s
🟩 gpu
  🟩 v100               Pass: 100%/110 | Total: 18h 29m | Avg: 10m 05s | Max:  1h 02m | Hits:  99%/3028  
🟩 jobs
  🟩 Build              Pass: 100%/102 | Total: 15h 09m | Avg:  8m 55s | Max:  1h 02m | Hits:  99%/3028  
  🟩 DeviceLaunch       Pass: 100%/1   | Total: 24m 00s | Avg: 24m 00s | Max: 24m 00s
  🟩 GraphCapture       Pass: 100%/1   | Total: 20m 04s | Avg: 20m 04s | Max: 20m 04s
  🟩 HostLaunch         Pass: 100%/3   | Total:  1h 12m | Avg: 24m 04s | Max: 28m 09s
  🟩 TestGPU            Pass: 100%/3   | Total:  1h 23m | Avg: 27m 46s | Max: 33m 55s
🟩 sm
  🟩 60;70;80;90        Pass: 100%/3   | Total: 31m 38s | Avg: 10m 32s | Max: 10m 52s
  🟩 90a                Pass: 100%/4   | Total: 24m 40s | Avg:  6m 10s | Max:  6m 13s
🟩 std
  🟩 11                 Pass: 100%/30  | Total:  4h 28m | Avg:  8m 57s | Max: 26m 18s
  🟩 14                 Pass: 100%/29  | Total:  5h 03m | Avg: 10m 27s | Max:  1h 02m | Hits:  99%/1514  
  🟩 17                 Pass: 100%/27  | Total:  3h 43m | Avg:  8m 16s | Max: 12m 56s | Hits:  99%/757   
  🟩 20                 Pass: 100%/24  | Total:  5h 13m | Avg: 13m 04s | Max: 33m 55s | Hits:  99%/757

  • 🟩 cccl_c_parallel: Pass: 100%/2 | Total: 10m 22s | Avg: 5m 11s | Max: 8m 14s

     
    🟩 cpu
  🟩 amd64              Pass: 100%/2   | Total: 10m 22s | Avg:  5m 11s | Max:  8m 14s
🟩 ctk
  🟩 12.6               Pass: 100%/2   | Total: 10m 22s | Avg:  5m 11s | Max:  8m 14s
🟩 cudacxx
  🟩 nvcc12.6           Pass: 100%/2   | Total: 10m 22s | Avg:  5m 11s | Max:  8m 14s
🟩 cudacxx_family
  🟩 nvcc               Pass: 100%/2   | Total: 10m 22s | Avg:  5m 11s | Max:  8m 14s
🟩 cxx
  🟩 GCC13              Pass: 100%/2   | Total: 10m 22s | Avg:  5m 11s | Max:  8m 14s
🟩 cxx_family
  🟩 GCC                Pass: 100%/2   | Total: 10m 22s | Avg:  5m 11s | Max:  8m 14s
🟩 gpu
  🟩 v100               Pass: 100%/2   | Total: 10m 22s | Avg:  5m 11s | Max:  8m 14s
🟩 jobs
  🟩 Build              Pass: 100%/1   | Total:  2m 08s | Avg:  2m 08s | Max:  2m 08s
  🟩 Test               Pass: 100%/1   | Total:  8m 14s | Avg:  8m 14s | Max:  8m 14s

  • 🟩 python: Pass: 100%/1 | Total: 14m 09s | Avg: 14m 09s | Max: 14m 09s

     
    🟩 cpu
  🟩 amd64              Pass: 100%/1   | Total: 14m 09s | Avg: 14m 09s | Max: 14m 09s
🟩 ctk
  🟩 12.6               Pass: 100%/1   | Total: 14m 09s | Avg: 14m 09s | Max: 14m 09s
🟩 cudacxx
  🟩 nvcc12.6           Pass: 100%/1   | Total: 14m 09s | Avg: 14m 09s | Max: 14m 09s
🟩 cudacxx_family
  🟩 nvcc               Pass: 100%/1   | Total: 14m 09s | Avg: 14m 09s | Max: 14m 09s
🟩 cxx
  🟩 GCC13              Pass: 100%/1   | Total: 14m 09s | Avg: 14m 09s | Max: 14m 09s
🟩 cxx_family
  🟩 GCC                Pass: 100%/1   | Total: 14m 09s | Avg: 14m 09s | Max: 14m 09s
🟩 gpu
  🟩 v100               Pass: 100%/1   | Total: 14m 09s | Avg: 14m 09s | Max: 14m 09s
🟩 jobs
  🟩 Test               Pass: 100%/1   | Total: 14m 09s | Avg: 14m 09s | Max: 14m 09s

👃 Inspect Changes

Modifications in project?

Project
CCCL Infrastructure
libcu++
+/- CUB
Thrust
CUDA Experimental
python
CCCL C Parallel Library
Catch2Helper

Modifications in project or dependencies?

Project
CCCL Infrastructure
libcu++
+/- CUB
+/- Thrust
CUDA Experimental
+/- python
+/- CCCL C Parallel Library
+/- Catch2Helper

🏃‍ Runner counts (total jobs: 224)
# Runner
185 linux-amd64-cpu16
16 linux-arm64-cpu16
14 linux-amd64-gpu-v100-latest-1
9 windows-amd64-cpu16

@bernhardmgruber bernhardmgruber merged commit 9af2a13 into NVIDIA:main Nov 21, 2024
242 checks passed
@bernhardmgruber bernhardmgruber deleted the ref_nvbench branch November 21, 2024 15:14
davebayer pushed a commit to davebayer/cccl that referenced this pull request Nov 21, 2024
@bernhardmgruber @davebayer
Refactoring (NVIDIA#2905)
07ece23
pciolkosz pushed a commit to pciolkosz/cccl that referenced this pull request Nov 22, 2024
@bernhardmgruber @pciolkosz
Refactoring (NVIDIA#2905)
43796c8
davebayer pushed a commit to davebayer/cccl that referenced this pull request Nov 22, 2024
@bernhardmgruber @davebayer
Refactoring (NVIDIA#2905)
6b5fa22
trxcllnt pushed a commit to trxcllnt/cccl that referenced this pull request Nov 23, 2024
@bernhardmgruber @trxcllnt
Refactoring (NVIDIA#2905)
3a1ecef
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miscco miscco miscco approved these changes

@elstehle elstehle Awaiting requested review from elstehle elstehle is a code owner automatically assigned from NVIDIA/cccl-cub-codeowners

@gonidelis gonidelis Awaiting requested review from gonidelis gonidelis is a code owner automatically assigned from NVIDIA/cccl-codeowners

Assignees
No one assigned
Labels
benchmark Feature related to benchmarking our libraries
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bernhardmgruber @miscco