Skip to content

Commit

Permalink
Fix empty clusterIP when no clusterIP is defined in values (#426)
Browse files Browse the repository at this point in the history
```
clusterIP:
```
Should only show up in manifest if `.Values.service.clusterIP` is defined. Otherwise it shows an empty value, which causes argoCD to report app as out of sync because of expects `spec.clusterIP` to have the auto assigned IP but manifest states it should be null value.
  • Loading branch information
nebula-it authored Dec 2, 2024
1 parent b97b763 commit d03881d
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion deployment/templates/service.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ metadata:
{{- end }}
spec:
type: {{ .Values.service.type }}
{{- if eq .Values.service.type "ClusterIP" }}
{{- if .Values.service.clusterIP }}
clusterIP: {{ .Values.service.clusterIP | quote }}
{{- end }}
ports:
Expand Down

0 comments on commit d03881d

Please sign in to comment.