pkg/dcgmexporter/gpu_collector.go: include a err_msg label in metric DCGM_FI_DEV_XID_ERRORS #309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bom-d-van
force-pushed
the
add-xid-error-label-hint
branch
3 times, most recently
from
93f36ee to
ad53c4a
Compare
|
@bom-d-van , Thank you for your contribution. Can you describe your use case to justify the change? |
|
Hi @nvvfedorov , this is to make it easy to generate alarm messages using the metric. For example, we could write a query like this to generate an alarm and use the err_msg in the template to make the error message easy to read. |
glowkey
reviewed
Apr 16, 2024
bom-d-van
commented
Apr 25, 2024
|
@bom-d-van , Please sign your commits and squash your commits into a single one. Then I will be ready to merge changes. |
bom-d-van
force-pushed
the
add-xid-error-label-hint
branch
from
551817f to
d689096
Compare
|
@nvvfedorov should be done now. could you take another look? tx. |
bom-d-van
force-pushed
the
add-xid-error-label-hint
branch
from
d689096 to
6c7e0c7
Compare
…DCGM_FI_DEV_XID_ERRORS The DCGM_FI_DEV_XID_ERRORS metric reports xid error code as its value, this commit includes an err_msg label with value retrieved from this nvidia doc: https://docs.nvidia.com/deploy/xid-errors/#topic_4 pkg/dcgmexporter/gpu_collector.go: include err_code label in metrics for easy alert configs pkg/dcgmexporter/gpu_collector.go: convert xidErrCodeToText to a slice and adjust the known value sanity check Signed-off-by: Xiaofan Hu <[email protected]> Signed-off-by: Vadym Fedorov <[email protected]>
Signed-off-by: Vadym Fedorov <[email protected]>
Signed-off-by: Vadym Fedorov <[email protected]>
nvvfedorov
force-pushed
the
add-xid-error-label-hint
branch
from
6c7e0c7 to
fb0f407
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The DCGM_FI_DEV_XID_ERRORS metric reports xid error code value, this commit include a err_msg label with value retrieved from this nvidia doc: https://docs.nvidia.com/deploy/xid-errors/#topic_4