Allow selecting the service's ClusterIP #375
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remram44
force-pushed
the
chart-clusterip
branch
from
578e7d7 to
ca6080e
Compare
|
Bump |
glowkey
approved these changes
Oct 23, 2024
|
The commit needs to be signed (git commit -S) before it can be merged. |
remram44
force-pushed
the
chart-clusterip
branch
from
ca6080e to
f5a3ed7
Compare
|
The commit is signed-off ( |
|
Sorry for the confusion. The contribution guide needs to be updated as the repository rules prevent us from merging commits that have not been signed with "git commit -S". |
This is mostly useful to be able to set it to "None", creating a headless service that can be scraped using DNS discovery (dns_sd_configs). Signed-off-by: Remi Rampin <[email protected]>
remram44
force-pushed
the
chart-clusterip
branch
from
f5a3ed7 to
9e2c741
Compare
|
Please fix your contributing guide ASAP, a guide with the wrong instructions is worse than no guide at all. I signed the commit so you can be sure the owner of this GitHub account is the owner of this GitHub account... really confused as to what this does for security, but here you go. |
|
We've asked the admins to change this rule to make future contributions easier. Thanks for your help! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is mostly useful to be able to set it to "None", creating a headless service that can be scraped using DNS discovery (dns_sd_configs).
No change in default behavior.