Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Helm Templates Generation #406

Merged
merged 1 commit into from
Oct 25, 2024
Merged

Fix Helm Templates Generation #406

merged 1 commit into from
Oct 25, 2024

Conversation

Indresh2410
Copy link
Contributor

Issue: #405

@glowkey
Copy link
Collaborator

glowkey commented Oct 23, 2024

The commit needs to be signed (git commit -S) before it can be merged.

@Indresh2410
Copy link
Contributor Author

Hi @glowkey . Thanks for reviewing. The commit is already signed
2554e4c

Not sure if we are missing something here. Can you please help here?

@glowkey
Copy link
Collaborator

glowkey commented Oct 24, 2024

Check out this link: https://docs.github.com/en/authentication/managing-commit-signature-verification/about-commit-signature-verification
If you look at your commit, you'll notice it does not have the "Verified" tag.

@Indresh2410
Fix Helm Templates Generation
f64764b 
Signed-off-by: Indresh Prakash <[email protected]>
@Indresh2410 Indresh2410 force-pushed the fix-helm-templates-in-local branch from 2554e4c to f64764b Compare October 25, 2024 05:48
@Indresh2410
Copy link
Contributor Author

Indresh2410 commented Oct 25, 2024 •
edited
Loading

Thanks @glowkey . Addressed it. Thanks for pointing out 😄 . If there are no issues, can we please merge the PR?

@glowkey glowkey merged commit 4cc1d19 into NVIDIA:main Oct 25, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glowkey glowkey glowkey approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Indresh2410 @glowkey