Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛[BUG]: IFS DataSource using t2m, msl, tcwv from 12h behind instead of current Initial Conditions #201

Open
david5010 opened this issue Nov 19, 2024 · 0 comments
Labels
? - Needs Triage Need team to review and classify bug Something isn't working

Comments

@david5010
Copy link

Version

source-main

On which installation method(s) does this occur?

No response

Describe the issue

I've rewritten part of the IFS initial conditions, but I realized that some of the parameters are using past 12h, but I don't remember the paper mentioning that FourCastnet uses it. Are those parameters there for GraphCast and/or other models? Looking at Earth2Studio, I don't see them doing this either

    channel_data = [
        _get_channel(
            c,
            u10m=dataset_0h.u10,
            v10m=dataset_0h.v10,
            u100m=dataset_0h.u100,
            v100m=dataset_0h.v100,
            sp=dataset_0h.sp,
            # ? Why is it 12h past? Should we switch it?
            t2m=forecast_12h.t2m,
            msl=forecast_12h.msl,
            tcwv=forecast_12h.tcwv,
            t=dataset_0h.t,
            u=dataset_0h.u,
            v=dataset_0h.v,
            r=dataset_0h.r,
            z=dataset_0h.gh * 9.81,
        )
        for c in channels
    ]

Environment details

@david5010 david5010 added ? - Needs Triage Need team to review and classify bug Something isn't working labels Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
? - Needs Triage Need team to review and classify bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant