Skip to content

Commit

Permalink
EmbeddedPkg/RealTimeClockLib: drop LibRtcVirtualNotifyEvent from lib …
Browse files Browse the repository at this point in the history
…class

The RealTimeClockLib class header in edk2 mistakenly declares a function
called LibRtcVirtualNotifyEvent(). No component ever calls this function
crossing module boundaries; all RealTimeClockLib instances in edk2 and
edk2-platforms are supposed to register (and do register) their
SetVirtualAddressMap() notification functions.

At this point, the word "LibRtcVirtualNotifyEvent" no longer occurs in any
of edk2, edk2-platforms, even edk2-non-osi, except the library class
header proper. Remove the LibRtcVirtualNotifyEvent() function declaration.

Build-tested only (with "EmbeddedPkg.dsc").

Cc: Abner Chang <[email protected]>
Cc: Ard Biesheuvel <[email protected]>
Cc: Daniel Schaefer <[email protected]>
Cc: Leif Lindholm <[email protected]>
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=4564
Signed-off-by: Laszlo Ersek <[email protected]>
Message-Id: <[email protected]>
Reviewed-by: Ard Biesheuvel <[email protected]>
  • Loading branch information
lersek authored and mergify[bot] committed Oct 18, 2023
1 parent 3c3136d commit 7fe4988
Showing 1 changed file with 0 additions and 15 deletions.
15 changes: 0 additions & 15 deletions EmbeddedPkg/Include/Library/RealTimeClockLib.h
Original file line number Diff line number Diff line change
Expand Up @@ -105,19 +105,4 @@ LibRtcInitialize (
IN EFI_SYSTEM_TABLE *SystemTable
);

/**
Fixup internal data so that EFI can be call in virtual mode.
Call the passed in Child Notify event and convert any pointers in
lib to virtual mode.
@param[in] Event The Event that is being processed
@param[in] Context Event Context
**/
VOID
EFIAPI
LibRtcVirtualNotifyEvent (
IN EFI_EVENT Event,
IN VOID *Context
);

#endif

0 comments on commit 7fe4988

Please sign in to comment.