Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't hardcode arch dir when symlinking mellanox ofa_kernel headers #17

Merged
merged 1 commit into from
Mar 26, 2024

Conversation

tariq1890
Copy link
Contributor

Same changes as #15 but for centos7 and rhel9. Also includes quoting of paths to avoid word splitting and globs as per shellcheck best practices

See here for more details on the shellcheck fix

@tariq1890 tariq1890 self-assigned this Mar 26, 2024
Copy link
Contributor

@shivamerla shivamerla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@tariq1890 tariq1890 merged commit e736f19 into main Mar 26, 2024
7 checks passed
@tariq1890 tariq1890 deleted the uname-m branch March 26, 2024 23:44
mikemckiernan added a commit to NVIDIA/cloud-native-docs that referenced this pull request Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants