remove centos7 support, bump cuda and go versions #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tariq Ibrahim <[email protected]>
cdesiniotis
approved these changes
Apr 11, 2024
|
As a general comment. Could we keep commits for changes such as these separate. We don't need separate PRs, but reverting or cherrypicking a subset of these changes is simpler if they are separate commits. |
elezar
reviewed
Apr 12, 2024
| @@ -112,10 +112,6 @@ trigger-pipeline: | |||
| variables: | |||
| DIST: rhel9 | |||
|
|
|||
| .dist-centos7: | |||
There was a problem hiding this comment.
Do we want to add a note to the centos7 folder in the repo to indicate that it is no longer supported?
elezar
reviewed
Apr 12, 2024
| @@ -1,6 +1,6 @@ | |||
| module vgpu-util | |||
|
|
|||
| go 1.20 | |||
| go 1.22.2 | |||
There was a problem hiding this comment.
Can we revert this instead? This indicate the MINIMUM go version required and does not affect the tooling choice.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As cuda version
12.4.1is no longer available forcentos, we remove support for centos