Skip to content

Commit

Permalink
Merge pull request #884 from elezar/use-only-ubi8-images
Browse files Browse the repository at this point in the history
Remove Ubuntu 22.04 images
  • Loading branch information
elezar authored Aug 12, 2024
2 parents 650a3af + 7cea228 commit adc69dc
Show file tree
Hide file tree
Showing 8 changed files with 7 additions and 136 deletions.
28 changes: 0 additions & 28 deletions .common-ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -73,10 +73,6 @@ trigger-pipeline:
variables:
DIST: "ubi8"

.dist-ubuntu22.04:
variables:
DIST: "ubuntu22.04"

# Define the platform targets
.platform-amd64:
variables:
Expand Down Expand Up @@ -123,23 +119,6 @@ trigger-pipeline:
- .scan-base

# Define the scan targets
scan-ubuntu22.04-amd64:
extends:
- .scan
- .dist-ubuntu22.04
- .platform-amd64
needs:
- image-ubuntu22.04

scan-ubuntu22.04-arm64:
extends:
- .scan
- .dist-ubuntu22.04
- .platform-arm64
needs:
- image-ubuntu22.04
- scan-ubuntu22.04-amd64

scan-ubi8-amd64:
extends:
- .scan
Expand Down Expand Up @@ -230,10 +209,3 @@ release:staging-ubi8:
- .dist-ubi8
needs:
- image-ubi8

release:staging-ubuntu22.04:
extends:
- .release:staging
- .dist-ubuntu22.04
needs:
- image-ubuntu22.04
5 changes: 1 addition & 4 deletions .github/workflows/image.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -31,9 +31,6 @@ on:
jobs:
build:
runs-on: ubuntu-latest
strategy:
matrix:
dist: [ubuntu22.04, ubi8]
steps:
- uses: actions/checkout@v4
name: Check out code
Expand Down Expand Up @@ -72,4 +69,4 @@ jobs:
VERSION: ${COMMIT_SHORT_SHA}
run: |
echo "${VERSION}"
make -f deployments/container/Makefile build-${{ matrix.dist }}
make -f deployments/container/Makefile build
19 changes: 1 addition & 18 deletions .nvidia-ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -70,11 +70,6 @@ image-ubi8:
- .image-pull
- .dist-ubi8

image-ubuntu22.04:
extends:
- .image-pull
- .dist-ubuntu22.04

# We skip the integration tests for the internal CI:
.integration:
stage: test
Expand Down Expand Up @@ -118,11 +113,6 @@ image-ubuntu22.04:

# Define the external release targets
# Release to NGC
release:ngc-ubuntu22.04:
extends:
- .release:ngc
- .dist-ubuntu22.04

release:ngc-ubi8:
extends:
- .release:ngc
Expand Down Expand Up @@ -170,17 +160,10 @@ sign:ngc-short-tag:
extends:
- .sign:ngc
needs:
- release:ngc-ubuntu22.04
- release:ngc-ubi8
variables:
IMAGE_TAG: "${CI_COMMIT_TAG}"

sign:ngc-ubuntu22.04:
extends:
- .dist-ubuntu22.04
- .sign:ngc
needs:
- release:ngc-ubuntu22.04

sign:ngc-ubi8:
extends:
- .dist-ubi8
Expand Down
4 changes: 2 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -951,7 +951,7 @@ Option 2, build without cloning the repository:
```shell
$ docker build \
-t nvcr.io/nvidia/k8s-device-plugin:devel \
-f deployments/container/Dockerfile.ubuntu \
-f deployments/container/Dockerfile \
https://github.com/NVIDIA/k8s-device-plugin.git#v0.16.2
```

Expand All @@ -960,7 +960,7 @@ Option 3, if you want to modify the code:
$ git clone https://github.com/NVIDIA/k8s-device-plugin.git && cd k8s-device-plugin
$ docker build \
-t nvcr.io/nvidia/k8s-device-plugin:devel \
-f deployments/container/Dockerfile.ubuntu \
-f deployments/container/Dockerfile \
.
```

Expand Down
1 change: 0 additions & 1 deletion demo/clusters/kind/scripts/common.sh
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,6 @@ DRIVER_IMAGE_REGISTRY=$(from_versions_mk "REGISTRY")
DRIVER_IMAGE_VERSION=$(from_versions_mk "VERSION")

: ${DRIVER_IMAGE_NAME:=${DRIVER_NAME}}
: ${DRIVER_IMAGE_PLATFORM:="ubuntu22.04"}
: ${DRIVER_IMAGE_TAG:=${DRIVER_IMAGE_VERSION}}
# The derived name of the driver image to build
: ${DRIVER_IMAGE:="${DRIVER_IMAGE_REGISTRY}/${DRIVER_IMAGE_NAME}:${DRIVER_IMAGE_TAG}"}
Expand Down
File renamed without changes.
76 changes: 0 additions & 76 deletions deployments/container/Dockerfile.ubuntu

This file was deleted.

10 changes: 3 additions & 7 deletions deployments/container/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -38,8 +38,8 @@ OUT_IMAGE_TAG = $(OUT_IMAGE_VERSION)-$(DIST)
OUT_IMAGE = $(OUT_IMAGE_NAME):$(OUT_IMAGE_TAG)

##### Public rules #####
DEFAULT_PUSH_TARGET := ubuntu22.04
DISTRIBUTIONS = $(DEFAULT_PUSH_TARGET) ubi8
DEFAULT_PUSH_TARGET := ubi8
DISTRIBUTIONS = $(DEFAULT_PUSH_TARGET)

IMAGE_TARGETS := $(patsubst %,image-%,$(DISTRIBUTIONS))
BUILD_TARGETS := $(patsubst %,build-%,$(DISTRIBUTIONS))
Expand Down Expand Up @@ -69,7 +69,7 @@ push-%: DIST = $(*)
push-short: DIST = $(DEFAULT_PUSH_TARGET)

build-%: DIST = $(*)
build-%: DOCKERFILE = $(CURDIR)/deployments/container/Dockerfile.$(DOCKERFILE_SUFFIX)
build-%: DOCKERFILE = $(CURDIR)/deployments/container/Dockerfile

# Use a generic build target to build the relevant images
$(IMAGE_TARGETS): image-%:
Expand All @@ -86,10 +86,6 @@ $(IMAGE_TARGETS): image-%:
-f $(DOCKERFILE) \
$(CURDIR)

build-ubuntu%: DOCKERFILE_SUFFIX := ubuntu

build-ubi8: DOCKERFILE_SUFFIX := ubi8

# Handle the default build target.
.PHONY: build
build: $(DEFAULT_PUSH_TARGET)
Expand Down

0 comments on commit adc69dc

Please sign in to comment.