-
Notifications
You must be signed in to change notification settings - Fork 207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Debian 11 repo is broken #218
Comments
@MKrupauskas would switching to Our intent with the official documentation was to make the downloading the repository list file work across different distributions, but the In the Debian case, this is |
All these user complaints would be solved with a symlink 😉 |
@jonathanjsimon it's not quite a simple as that. A symlink duplicates the contents of the target folder at the link location when publishing these repos through GitHub pages. The reason this optimisation was performed was that the resultant artifact is already too large, causing the pages deployment to fail meaning that new packages are not available. We are aware that there may be ways to increase the timeout using custom pages deployments. If you have experience in how to do this, suggestions are welcome. |
While we did work around the issue by pointing our source list to Debian 10 the solution isn't ideal. If the only issue is the artifact size and build timeouts I think we should address that for the sake of having a Debian repo that matches the repo standard and user expectations. Could you share some logs on what exactly times out if we correctly symlink the distribution directories? Looking at github action docs the steps themselves shouldn't time out for 360m if the default isn't overridden https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#jobsjob_idstepstimeout-minutes |
@MKrupauskas I have made the symlink changes to my personal mirror elezar@98ee43d. The GitHub actions deploying this is here: A previous action shows the archive size warning: The following is an example of a deployment that failed due to a timeout, although this was using the "Deploy from branch" pages deployment and not an explicit workflow as we are using now. |
We have updated our repository structure and installation instructions to make use of generic debian packages. The distribution name no longer affects the instructions. Please see https://docs.nvidia.com/datacenter/cloud-native/container-toolkit/latest/install-guide.html and reopen this issue if there are still problems. |
Hi there, |
@HenriWahl I don't know what If there is additional metadata required by the toolking we could consider adding it. |
@elezar I am not sure what is missing, looks good to me. Edit: yes, there are some differences:
Edit 2: I found this being an older problem: NVIDIA/nvidia-docker#730 |
Those are useful pointers. I will spend some time investigating this. |
I have just tried the following in a clean
Could you confirm that |
Hi @elezar - thanks for your investigations! I can confirm that my Great job! 👍 |
@elezar one thing is left: now the I see it is even missing at https://github.com/NVIDIA/libnvidia-container/tree/gh-pages/stable/deb/amd64. |
From the following documentation: https://wiki.debian.org/DebianRepository/Format#Flat_Repository_Format it is unclear whether a Can you give more information on what |
After an
|
Does:
work as expected? |
Yes it does. The problem seems to be caused by apt-mirror, according to apt-mirror/apt-mirror#156. It seems to miss this file on flat repositories. I will look for it or an alternative next week. Thanks for your commitment! |
I think you can get by this by marking the local mirror as trusted or ensuring that the public key for our repos is also downloaded. For example, as per our documentation https://docs.nvidia.com/datacenter/cloud-native/container-toolkit/latest/install-guide.html#installing-with-apt:
Note that the lines effectively look like:
in this case and setting up something similar for your mirrors would be needed. |
The commit 2dff280 restructured the Debian 11 repo in a breaking way.
Previously the below setup used to work, now it's failing:
this is because
/debian11
used to symlink to/stable/debian11
which used to symlink/stable/debian10
which contained theamd64
directory with the .deb builds. https://github.com/NVIDIA/libnvidia-container/tree/9ce31ae4f042508cd8aabfad6168114c1cde30f0/debian10
,/debian11
,/stable/debian11
should all haveamd64
symlinks ultimately pointing to/stable/debian10/amd64
The text was updated successfully, but these errors were encountered: