Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EPIC] Create purely pythonic nv_ingest_common module #351

Open
jdye64 opened this issue Jan 20, 2025 · 0 comments
Open

[EPIC] Create purely pythonic nv_ingest_common module #351

jdye64 opened this issue Jan 20, 2025 · 0 comments
Assignees
Labels
epic high level feature/functionality

Comments

@jdye64
Copy link
Collaborator

jdye64 commented Jan 20, 2025

There is currently duplicative code in both nv_ingest and nv_ingest_client. The duplicative code ranges from Pydantic schemas that are needed in both modules to utility functions needed in both locations. The goal of this Epic is to setup a nv_ingest_common module that takes the duplicative code from each independent module and places it in a common/shared location.

Furthermore this module should be a lite and purely python as possible. This module should be written in a fashion where other libraries or runtimes can import it and use in a fashion similar to nv_ingest_runtime. This of course means that nv_ingest_runtime will need some refactoring to work with code that is moved to this common module.

This Epic can be broken down into the follows issues.

@jdye64 jdye64 added the epic high level feature/functionality label Jan 20, 2025
@jdye64 jdye64 self-assigned this Jan 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
epic high level feature/functionality
Projects
None yet
Development

No branches or pull requests

1 participant