Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEA] Add checkstyle for building. #2591

Open
liurenjie1024 opened this issue Nov 14, 2024 · 1 comment · May be fixed by #2610
Open

[FEA] Add checkstyle for building. #2591

liurenjie1024 opened this issue Nov 14, 2024 · 1 comment · May be fixed by #2610
Assignees
Labels

Comments

@liurenjie1024
Copy link
Collaborator

Is your feature request related to a problem? Please describe.
Currently we are missing format/style check during build.

Describe the solution you'd like
checkstyle is among the most popular formatters/linters in java ecosystem, and we should add support for it during build process.

Describe alternatives you've considered

No.

Additional context
No.

@pxLi
Copy link
Collaborator

pxLi commented Nov 20, 2024

JNI repo has the https://github.com/NVIDIA/spark-rapids-jni/blob/branch-24.12/.github/workflows/clang-format.yml

if we would like to have some check for java/scala code, please help provide the command or add the process to maven stages like plugin https://github.com/NVIDIA/spark-rapids/blob/branch-24.12/pom.xml#L1703-L1710 firstly @liurenjie1024 thanks

@liurenjie1024 liurenjie1024 linked a pull request Nov 20, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants