Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEA] use binary search to advance to the next cudf commit in submodule sync #2593

Open
gerashegalov opened this issue Nov 14, 2024 · 0 comments
Labels

Comments

@gerashegalov
Copy link
Collaborator

gerashegalov commented Nov 14, 2024

Is your feature request related to a problem? Please describe.

submodule-sync.sh is all-or-nothing currently. Recently there we ran into two commits breaking spark-rapids-jni

rapidsai/cudf@918266a
rapidsai/cudf@6acd33d

In general there could be a lot of commits between breaking commit A and a more recent breaking commit B. If A is fixed and B is not, submodule-sync would fail to advance the submodule missing on all the commits including B^

Describe the solution you'd like
It would be great to use binary search via git bisect to find the most recent advance-able cudf commit

Added benefit: output the earliest cudf commit breaking spark-rapids-jni

Describe alternatives you've considered
Keep current behavior of waiting until the most recent commit is workable

Additional context

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants