Update spark_resource_adaptor for rmm's device_async_resource_ref #2064
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Paul Mattione <[email protected]>
|
/build |
pmattione-nvidia
changed the title
|
This is not ready for review, but I have to formally open it to test the builds :/ |
|
/build |
|
build |
1 similar comment
|
build |
|
Note that the cuDF submodule will need to updated once the corresponding cuDF PR goes in |
|
@pmattione-nvidia please retarget to 24.10. |
Done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switch rmm device_memory_resource to device_async_resource_ref in the spark_resource_adaptor class.