-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add agency budget filter to capital projects endpoint #402
Comments
From our discussion at Sprint Planning, we talked briefly about validating that a "Project Type" actually existed. I mentioned we recently refactored this from an enum to a check constraint. This was incorrect, simply because I was referring to the "category" field of the capital project table. For project type, as in a "type" field on the "capital project" table. Well, that doesn't exist (ERD below). From the designs, I think we're referring to the Agency Budget Type. I think this is good news. It's straightforward to create an endpoint where we return the list of fields for each agency budget (Example Query Result Below). We should also expect API users to pass the "code" as the value of the "projectType" query parameter. In which case, we're using the Primary Key index and performance should be acceptable. I would suggest that we change the parameter name from "project type" to something like "agency budget code". No opinion on whether we change the name of the input in the frontend. |
- modified open api docs with agency budget param - modified findMany in repo to accept agency budget param - modify service findMany to filter by agency budget code - update repo mock, e2e test, service tests Closes #402
- modified open api docs with agency budget param - modified findMany in repo to accept agency budget param - modify service findMany to filter by agency budget code - update repo mock, e2e test, service tests Closes #402
Acceptance Criteria
capital-projects
endpoint has an optionalagencyBudget
query parameter that allows the user to filter by agency budgetcapital-project
is included in the response if any of its commitments are funded by the specified agency budgetcode
for an agency budgetValidation
The text was updated successfully, but these errors were encountered: