Found some dead code

[sgpthomas]

rrr/pylib/simplerpc/Server.py never gets run. Consequently, _pyrpc_init_server, _pyrpc_fini_server, _pyrpc_server_start, _pyrpc_server_unreg, _pyrpc_server_reg also never get run

[sgpthomas]

you can verify this by commenting out from simplerpc.server import Server from the __init__.py in rrr/pylib/simplerpc

[shuaimu]

Thanks for report. I will let this issue stay open because I think perhaps we should replace this cross-language rpc module into something more stable and easier to use: e.g. grpc. When we started this project (2013), I think grpc was not released yet so we had to write our own.

Just curious, did you find out through some code analysis tool or manually?

[sgpthomas]

I found it manually. I'm doing work with your experimental scripts to replicate your results and to understand how they work as part of DSEF. I discovered this while trying to run all experiments from run.py instead of calling separate run.py commands from run_all.py. I'm doing this for organization purposes and so that I can keep the data as python objects instead of serializing it to yaml and then reading it later. This probably doesn't make it immediately obvious why I'm doing this but I would be happy to tell you more about the project if you're interested.

Anyways, not restarting run.py after each experiment causes a nasty segmentation fault and it seems to have something to do with the custom python module. In tracking down this segmentation fault, I discovered the unused code.

[sgpthomas]

P.S. Our github page is pretty dead write now because a lot of what we've been doing recently isn't writing code, but working with other people's experiments

[shuaimu]

I see. Good work! I like the idea of a general testing framework. Let me know of any issues you have setting up janus.