Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code review ideas: internationalise the parameters #16

Open
ghost opened this issue Jul 26, 2016 · 1 comment
Open

Code review ideas: internationalise the parameters #16

ghost opened this issue Jul 26, 2016 · 1 comment

Comments

@ghost
Copy link

ghost commented Jul 26, 2016

make_files.py;

print >> f, '''15.000 ; Earth Dielectric Constant (Relative permittivity) 0.005 ; Earth Conductivity (Siemens per meter) 301.000 ; Atmospheric Bending Constant (N-units) '''+ inner_dict['frequency_mhz'] + ''' ; Frequency in MHz (20 MHz to 20 GHz) 6 ; Maritime Temperate, over land (UK and west coasts of US & EU) ''' + pol + ''' ; Polarization (0 = Horizontal, 1 = Vertical) 0.5 ; Fraction of situations (50% of locations) 0.5 ; Fraction of time (50% of the time) ''' + inner_dict['power_eirp'] + ''' ; ERP in watts'''

These parameters could be internationalised into a dict, enabling other users to contribute back their dicts rather than just getting the code and localising the parameters

@jamiesgithub
Copy link

These parameters are not super localised. Its very macro. It would be great to have a way to define what they are, but there won't be others contributing back their own dicts....

7 Climate
4 Soli permittivity

http://www.softwright.com/faq/engineering/prop_longley_rice.html

Please make it happen though

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant