Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NanoVNASaver 0.55, bug: Th e delay of the open calibration standard is not taken into account. This is caused by a name/typo error in the file CalibrationSettings.py. In line 550 openLength must be corrected to open_length. #663

Open
PA0JOZ opened this issue Jul 25, 2023 · 1 comment
Open

NanoVNASaver 0.55, bug: Th e delay of the open calibration standard is not taken into account. This is caused by a name/typo error in the file CalibrationSettings.py. In line 550 openLength must be corrected to open_length. #663

PA0JOZ opened this issue Jul 25, 2023 · 1 comment
Labels
bug Something isn't working

Comments

@PA0JOZ
Copy link

PA0JOZ commented Jul 25, 2023

Bug Report

**NanoVNA-Saver version: 0.55

**Current behavior: The delay of the open calibration standard is not taken into account.

**Expected behavior: The open delay must be taken into account during calibration. The delay of the short and load standards are taken account.

**Steps to reproduce: Do a calibration with different delay values and check the calibration result (phase of the open standard after calibration)

**Related code: CalibrationSettings.py, line 550: openLength should be open_length

cal_element.openLength = getFloatValue(
                self.load_length.text()) / 1.0e12

should be:

cal_element.open_length = getFloatValue(
                self.load_length.text()) / 1.0e12

Regards, 73, Jos, PA0JOZ
@PA0JOZ PA0JOZ added the bug Something isn't working label Jul 25, 2023
@t52ta6ek t52ta6ek mentioned this issue Jul 30, 2023
Closed
t52ta6ek added a commit to t52ta6ek/nanovna-saver that referenced this issue Jul 30, 2023
@t52ta6ek
Control panel width increased a few pixels to allow Markers -> "refer…
995ae02 
…ence" checkbox to be capitalized like the other checkboxes and radio buttons. Now able to be displayed as "Reference" without cutting off the text of the "Enable Delta Marker" checkbox.

Added icon_48x48.ico so that pyinstaller/auto-py-to-exe can create a Windows executable with the actual NanoVNA-Saver project icon instead of a generic Python icon. The .ico was created by converting the icon_48x48.png image.

"Files" button in control panel changed to "Files ..." to be consistent with other "..." actions where a user will take additional action after pressing the button.

Minor corrections in the Calibration page "Are you sure?" and "Calibration assistant" pop-ups where text was being run together. e.g. "doso" instead of "do so" etc.

Fix issue: NanoVNA-Saver#663
@t52ta6ek t52ta6ek mentioned this issue Jul 30, 2023
Merged
6 tasks
zarath pushed a commit that referenced this issue Jul 30, 2023
@t52ta6ek
Control panel width increased a few pixels to allow Markers -> "refer…
5bed1bc 
…ence" checkbox to be capitalized like the other checkboxes and radio buttons. Now able to be displayed as "Reference" without cutting off the text of the "Enable Delta Marker" checkbox. (#665)

Added icon_48x48.ico so that pyinstaller/auto-py-to-exe can create a Windows executable with the actual NanoVNA-Saver project icon instead of a generic Python icon. The .ico was created by converting the icon_48x48.png image.

"Files" button in control panel changed to "Files ..." to be consistent with other "..." actions where a user will take additional action after pressing the button.

Minor corrections in the Calibration page "Are you sure?" and "Calibration assistant" pop-ups where text was being run together. e.g. "doso" instead of "do so" etc.

Fix issue: #663
@t52ta6ek
Copy link
Contributor

t52ta6ek commented Jul 30, 2023 •
edited
Loading

@PA0JOZ - Tnx for the tip. Was making some other changes to this file and included your fix. Pls try and close issue if working now. 73!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@t52ta6ek @PA0JOZ