Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the quirk where the engine jar file is retrieved as a binary in a source workspace under certain circumstances #85

Open
Cervator opened this issue Aug 5, 2016 · 0 comments

Comments

@Cervator
Copy link
Member

Cervator commented Aug 5, 2016

Need to add a dependency resolution exclude for the engine when modules check dependency resolution in a local source workspace, should always use local engine instead of grabbing a jar from Artifactory. As one example it happened from a plain "gradlew idea" with Holdings downloaded as source solo (making it pull some module binaries)

This is likely caused when a local source module has a transitive dependency not available in source form and THAT dependency then downloaded as a jar from Artifactory (with a .pom) has a transitive dependency on Core, which has a transitive dependency on a SPECIFIC version of the engine ... you can observe that by looking at the submitted .pom for Core in Artifactory. Instead it should be assumed the engine is ALWAYS taken in source from locally and not resolved from Artifactory ? And Core too, really, since it is in the same repo as engine.

On the other hand this might better be fixed by cleaning up resulting module .pom files. Quite possibly they should be written with the engine dependency excluded? Since there's no sensible setup where they are "lacking" an engine or are able to run with a different version of the engine than the one present (source or binary). Maybe a provided or compileOnly thing would keep the engine out of the .pom

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant