Update RegressionTest to assume UTF-8. #1006
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dev-mlb
requested changes
Nov 7, 2024
fbruton
previously requested changes
Nov 15, 2024
dev-mlb
approved these changes
Nov 25, 2024
ldhardy
approved these changes
Nov 26, 2024
jpdahlke
added
the
integration
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates RegressionTest to assume all byte arrays are UTF-8 and not process them as ASCII (i.e. ISO_8859_1). The main benefit of this is that valid UTF-8 is output in the XML directly instead of being hashed or BASE64'd.
NOTE: This is a potentially "breaking" change that might require XML files to be regenerated.