Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ServiceConfigGuide bug. #586

Merged

Conversation

jdcove2
Copy link
Collaborator

@jdcove2 jdcove2 commented Sep 11, 2023

ServiceConfigGuide uses java.io.StreamTokenizer to parse the configuration data. StreamTokenizer returns two types of informational tokens, String and Number (i.e. double). ServiceConfigGuide converts Numbers to Strings using Integer.toString(). This limited the range of the number to that of an Integer. A "quick fix" to expand this range is to use Long.toString().

Copy link
Collaborator

@smcgrattan smcgrattan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jpdahlke jpdahlke added this to the v8.0.0-M5 milestone Sep 14, 2023
@jpdahlke jpdahlke added the bug Something isn't working as intended label Sep 15, 2023
@jpdahlke jpdahlke merged commit b53d14c into NationalSecurityAgency:master Sep 15, 2023
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working as intended
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants