Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KffFile cleanup #593

Merged
merged 2 commits into from
Sep 21, 2023
+3 −4
Merged

KffFile cleanup #593

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3bce395
Now capturing the call stack if there's an IOException reading the Kf…
drivenflywheel Sep 18, 2023
e66abdc
Minor whitespace cleanup, reduced level of log message in unit tests
drivenflywheel Sep 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions src/main/java/emissary/kff/KffFile.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -178,8 +178,7 @@ private boolean binaryFileSearch(@Nonnull byte[] hash, long crc) {
}
}
} catch (IOException e) {
logger.warn("Exception reading KffFile: {}", e.getMessage());
return false;
logger.warn("Exception reading KffFile", e);
}

// not found
Expand Down
4 changes: 2 additions & 2 deletions src/test/java/emissary/kff/KffFileTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,7 @@ void testConcurrentKffFileCheckCalls() throws Exception {

List<KffFileCheckTask> callables = createCallableTasksForParallelExecution(testInputs);

logger.info("testing {} invocations, with {} that should return true", callables.size(), numberOfKffEntriesInTestFile);
logger.debug("testing {} invocations, with {} that should return true", callables.size(), numberOfKffEntriesInTestFile);

ExecutorService executorService = null;
try {
Expand Down Expand Up @@ -272,7 +272,7 @@ static class KffFileCheckTask implements Callable<Boolean> {
public Boolean call() throws Exception {
boolean actual = kffFile.check("ignored param", csr);
// increase this log level to view stream of executions and results
LOGGER.info("expected {}, got {}", expectedResult, actual);
LOGGER.debug("expected {}, got {}", expectedResult, actual);
return expectedResult.equals(actual);
}
}
Expand Down
Loading