Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update IBaseDataObjectDiffHelperTest to extend unittest #597

Merged
merged 1 commit into from
Oct 2, 2023
Merged

update IBaseDataObjectDiffHelperTest to extend unittest #597

merged 1 commit into from
Oct 2, 2023

Conversation

dev-mlb
Copy link
Collaborator

@dev-mlb dev-mlb commented Sep 26, 2023

No description provided.

@dev-mlb dev-mlb mentioned this pull request Sep 26, 2023
Merged
drivenflywheel
drivenflywheel approved these changes Sep 28, 2023
View reviewed changes
Copy link
Collaborator

@drivenflywheel drivenflywheel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good find. I wonder if there's a way to automate detection of these cases..

@jpdahlke jpdahlke added this to the v8.0.0-M7 milestone Oct 2, 2023
@jpdahlke jpdahlke self-requested a review October 2, 2023 20:48
@jpdahlke jpdahlke merged commit e624a41 into master Oct 2, 2023
9 checks passed
@jpdahlke jpdahlke deleted the tests-ibdodht branch October 2, 2023 20:49
@jpdahlke jpdahlke added the test-only The change only impacts test code label Oct 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpdahlke jpdahlke jpdahlke approved these changes

@drivenflywheel drivenflywheel drivenflywheel approved these changes

@fbruton fbruton Awaiting requested review from fbruton

Assignees
No one assigned
Labels
test-only The change only impacts test code
Projects
None yet
Milestone
v8.0.0-M7
Development

Successfully merging this pull request may close these issues.
3 participants
@dev-mlb @drivenflywheel @jpdahlke