Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update tests to extend UnitTest #608

Merged
merged 2 commits into from
Oct 10, 2023
Merged

update tests to extend UnitTest #608

merged 2 commits into from
Oct 10, 2023

Conversation

dev-mlb
Copy link
Collaborator

@dev-mlb dev-mlb commented Oct 5, 2023

No description provided.

@dev-mlb dev-mlb requested a review from jpdahlke October 5, 2023 14:54
@jpdahlke jpdahlke added this to the v8.0.0-M8 milestone Oct 5, 2023
@jpdahlke jpdahlke added the test-only The change only impacts test code label Oct 6, 2023
jpdahlke
jpdahlke previously approved these changes Oct 6, 2023
src/test/java/emissary/util/DisposeHelperTest.java Outdated Show resolved Hide resolved
@drivenflywheel
Copy link
Collaborator

I've got no problem with updating each of these to extend UnitTest, but I thought (think?) we've only seen impact to other tests if the "non-UnitTest" test classes invoke code that leverages ConfigUtil. Is that not the case?

@dev-mlb
Copy link
Collaborator Author

dev-mlb commented Oct 7, 2023

I've got no problem with updating each of these to extend UnitTest, but I thought (think?) we've only seen impact to other tests if the "non-UnitTest" test classes invoke code that leverages ConfigUtil. Is that not the case?

Yep, that is true. I felt that I was in here anyways and should just have the tests extend UnitTest, hopefully, to future-proof it. Hopefully JUnit implements the @BeforeSuite/@AfterSuite, or what ever they end up calling it, and the need for this could probably go away. But the issues (456) has been open since 2016, so there's that.

@dev-mlb dev-mlb force-pushed the fix-failing-build branch from b85d652 to bcd0682 Compare October 7, 2023 12:13
@jpdahlke jpdahlke self-requested a review October 10, 2023 15:43
@jpdahlke jpdahlke merged commit 5e0db47 into master Oct 10, 2023
9 checks passed
@jpdahlke jpdahlke deleted the fix-failing-build branch October 10, 2023 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test-only The change only impacts test code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants