Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci :: updating docker compose to allow for testing #823

Merged
merged 6 commits into from
Sep 16, 2024

Conversation

dev-mlb
Copy link
Collaborator

@dev-mlb dev-mlb commented Jun 17, 2024

These docker file updates are meant for GitHub actions. For the standard build, it starts a feeder and server and checks to see if they come up. This is the first step in a longer effort to test the Emissary stars tup and processes a file successfully.

@dev-mlb dev-mlb added the CI/CD Changes to the CI/CD Pipeline label Jun 17, 2024
@dev-mlb dev-mlb changed the title updating docker compose to allow for ci testing ci :: updating docker compose to allow for testing Jun 17, 2024
@dev-mlb dev-mlb force-pushed the docker-compose-ci branch 2 times, most recently from 63c36af to 3787038 Compare June 18, 2024 11:13
@dev-mlb dev-mlb force-pushed the docker-compose-ci branch 2 times, most recently from 50adcd7 to f7a00bb Compare June 18, 2024 12:57
@dev-mlb dev-mlb force-pushed the docker-compose-ci branch from f7a00bb to 229a853 Compare June 18, 2024 13:01
@dev-mlb dev-mlb marked this pull request as draft June 18, 2024 18:03
@dev-mlb dev-mlb marked this pull request as ready for review June 20, 2024 15:42
@jpdahlke jpdahlke added this to the v8.6.0 milestone Jun 26, 2024
Copy link
Collaborator

@cfkoehler cfkoehler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected

@jpdahlke jpdahlke modified the milestones: v8.6.0, v8.7.0 Jun 27, 2024
@jpdahlke jpdahlke modified the milestones: v8.7.0, v8.8.0 Aug 1, 2024
cfkoehler
cfkoehler previously approved these changes Sep 10, 2024
@jpdahlke jpdahlke added this to the v8.12.0 milestone Sep 10, 2024
@jpdahlke jpdahlke requested a review from cfkoehler September 12, 2024 02:00
@jpdahlke
Copy link
Collaborator

docker compose -f contrib/docker/docker-compose.ubi8.yml up --build --exit-code-from emissary-server

@DonResnik
Copy link
Collaborator

@dev-mlb is there any value in adding a README on how to use docker-compose? I have a README for the burrito triton docker-compose effort on this branch https://github.com/NationalSecurityAgency/burrito-grande/blob/2905-use-ImageMagick-for-image-id/contrib/docker/README.md that might be pretty easy edit for emissary.

@DonResnik
Copy link
Collaborator

running docker compose -f contrib/docker/docker-compose.ubi8.yml up --build --exit-code-from emissary-server successfully started emissary server

Copy link
Collaborator

@DonResnik DonResnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider adding README, detailed comment already added

@dev-mlb
Copy link
Collaborator Author

dev-mlb commented Sep 13, 2024

docker compose -f contrib/docker/docker-compose.ubi8.yml up --build --exit-code-from emissary-server

Whoops. First cut used the ubi8 yaml ... functionality moved to the ci yaml.

@dev-mlb
Copy link
Collaborator Author

dev-mlb commented Sep 13, 2024

@jpdahlke @cfkoehler @DonResnik Should we clean up the docker directory and remove some of the older files? Docker.ci contains ubi8, centos7, alpine, and the dev image all in one. I could remove those files and update the readme. Another option is to take this pr, and then I can target a clean up effort for Emissary 9?? Let me know your thoughts.

I could add this to the readme, but it is intended to use with GitHub actions. If we consolidate the docker stuff, I can redo all of the docker readme.

@DonResnik
Copy link
Collaborator

@dev-mlb - I would be good with committing this PR as is if you make another ticket that includes cleaning up the docker files and adding the README. I would be happy to work on that ticket if you don't have plans to do it already.

@DonResnik DonResnik self-requested a review September 16, 2024 15:18
@jpdahlke jpdahlke merged commit 36623d1 into NationalSecurityAgency:main Sep 16, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/CD Changes to the CI/CD Pipeline
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants