-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci :: updating docker compose to allow for testing #823
ci :: updating docker compose to allow for testing #823
Conversation
63c36af
to
3787038
Compare
50adcd7
to
f7a00bb
Compare
f7a00bb
to
229a853
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works as expected
|
@dev-mlb is there any value in adding a README on how to use docker-compose? I have a README for the burrito triton docker-compose effort on this branch https://github.com/NationalSecurityAgency/burrito-grande/blob/2905-use-ImageMagick-for-image-id/contrib/docker/README.md that might be pretty easy edit for emissary. |
running |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider adding README, detailed comment already added
Whoops. First cut used the ubi8 yaml ... functionality moved to the ci yaml. |
@jpdahlke @cfkoehler @DonResnik Should we clean up the docker directory and remove some of the older files? Docker.ci contains ubi8, centos7, alpine, and the dev image all in one. I could remove those files and update the readme. Another option is to take this pr, and then I can target a clean up effort for Emissary 9?? Let me know your thoughts. I could add this to the readme, but it is intended to use with GitHub actions. If we consolidate the docker stuff, I can redo all of the docker readme. |
@dev-mlb - I would be good with committing this PR as is if you make another ticket that includes cleaning up the docker files and adding the README. I would be happy to work on that ticket if you don't have plans to do it already. |
These docker file updates are meant for GitHub actions. For the standard build, it starts a feeder and server and checks to see if they come up. This is the first step in a longer effort to test the Emissary stars tup and processes a file successfully.