Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update command validation for mode value and use an enum for possible values #900

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

jpdahlke
Copy link
Collaborator

This quickly unraveled from a simple errorprone update for an UnusedMethod setMode into addressing a few touch points for this command option that weren't straightforward. This effort attempts to address a few things:

  • stop setting and then using an environment variable for mode
  • fully annotate the possible modes
  • allow mixed case values for mode at the command line
  • continue to validate the values provided by the user using picocli methods
  • clean up some setup exception handling

@dev-mlb
Copy link
Collaborator

dev-mlb commented Aug 29, 2024

Cluster mode seems to be broken...server and feeder start up, but register peer doesn't seem to fire...

2024-08-29T19:25:05.980 [localhost-8001] DEBUG emissary.directory.EmissaryNode -   - Node is standalone, ignoring any peer.cfg and only constructing one rendevous peer with the local node
2024-08-29T19:25:05.980 [localhost-8001] DEBUG emissary.directory.DirectoryPlace -   - Not adding peers in standalone nodes
2024-08-29T19:25:05.980 [localhost-8001] DEBUG emissary.directory.DirectoryPlace -   - Configured 0 rendezvous peers from 1 config entries.

@jpdahlke jpdahlke marked this pull request as draft August 30, 2024 02:11
@dev-mlb dev-mlb added the integration A breaking change where effort will be required downstream to resolve label Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integration A breaking change where effort will be required downstream to resolve
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants