Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

errorprone :: FlexibleDateTimeParser #931

Merged
merged 2 commits into from
Sep 30, 2024

Conversation

dev-mlb
Copy link
Collaborator

@dev-mlb dev-mlb commented Sep 14, 2024

[WARNING] /nsa-emissary/src/main/java/emissary/util/FlexibleDateTimeParser.java:[142,8] [ReturnMissingNullable] Method returns a definitely null value but is not annotated @Nullable
    (see https://errorprone.info/bugpattern/ReturnMissingNullable)
  Did you mean '@Nullable static ZonedDateTime lastDitchParsingEffort(final String date) {'?
[WARNING] /nsa-emissary/src/main/java/emissary/util/FlexibleDateTimeParser.java:[99,32] [UngroupedOverloads] Overloads should be grouped together, even when modifiers such as static or private differ between the methods; found ungrouped overloads of 'parse' on line(s): 171, 182
    (see https://errorprone.info/bugpattern/UngroupedOverloads)
  Did you mean to remove this line?
[WARNING] /nsa-emissary/src/main/java/emissary/util/FlexibleDateTimeParser.java:[111,32] [UngroupedOverloads] Overloads should be grouped together, even when modifiers such as static or private differ between the methods; found ungrouped overloads of 'parse' on line(s): 171, 182
    (see https://errorprone.info/bugpattern/UngroupedOverloads)
  Did you mean to remove this line?
[WARNING] /nsa-emissary/src/main/java/emissary/util/FlexibleDateTimeParser.java:[171,32] [UngroupedOverloads] Overloads should be grouped together, even when modifiers such as static or private differ between the methods; found ungrouped overloads of 'parse' on line(s): 99, 111
    (see https://errorprone.info/bugpattern/UngroupedOverloads)
  Did you mean to remove this line?
[WARNING] /nsa-emissary/src/main/java/emissary/util/FlexibleDateTimeParser.java:[183,32] [UngroupedOverloads] Overloads should be grouped together, even when modifiers such as static or private differ between the methods; found ungrouped overloads of 'parse' on line(s): 99, 111
    (see https://errorprone.info/bugpattern/UngroupedOverloads)
  Did you mean to remove this line?
[WARNING] /nsa-emissary/src/main/java/emissary/util/FlexibleDateTimeParser.java:[63,27] [NonFinalStaticField] Static fields should almost always be final.
    (see https://errorprone.info/bugpattern/NonFinalStaticField)
[WARNING] /nsa-emissary/src/main/java/emissary/util/FlexibleDateTimeParser.java:[68,27] [NonFinalStaticField] Static fields should almost always be final.
    (see https://errorprone.info/bugpattern/NonFinalStaticField)
[WARNING] /nsa-emissary/src/main/java/emissary/util/FlexibleDateTimeParser.java:[71,26] [NonFinalStaticField] Static fields should almost always be final.
    (see https://errorprone.info/bugpattern/NonFinalStaticField)
[WARNING] /nsa-emissary/src/main/java/emissary/util/FlexibleDateTimeParser.java:[74,43] [NonFinalStaticField] Static fields should almost always be final.
    (see https://errorprone.info/bugpattern/NonFinalStaticField)
[WARNING] /nsa-emissary/src/main/java/emissary/util/FlexibleDateTimeParser.java:[77,43] [NonFinalStaticField] Static fields should almost always be final.
    (see https://errorprone.info/bugpattern/NonFinalStaticField)


[WARNING] /nsa-emissary/src/test/java/emissary/util/FlexibleDateTimeParserTest.java:[47,24] [UngroupedOverloads] Overloads should be grouped together, even when modifiers such as static or private differ between the methods; found ungrouped overloads of 'test' on line(s): 96
    (see https://errorprone.info/bugpattern/UngroupedOverloads)
  Did you mean to remove this line?
[WARNING] /nsa-emissary/src/test/java/emissary/util/FlexibleDateTimeParserTest.java:[96,24] [UngroupedOverloads] Overloads should be grouped together, even when modifiers such as static or private differ between the methods; found ungrouped overloads of 'test' on line(s): 47
    (see https://errorprone.info/bugpattern/UngroupedOverloads)
  Did you mean to remove this line?

@dev-mlb dev-mlb added the tech-debt Low-impact cleanup and upkeep label Sep 14, 2024
@jpdahlke jpdahlke modified the milestones: v8.12.0, v8.13.0 Sep 16, 2024
@jpdahlke jpdahlke merged commit 9cb3238 into NationalSecurityAgency:main Sep 30, 2024
13 checks passed
@dev-mlb dev-mlb deleted the ep-flexdateparser branch September 30, 2024 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tech-debt Low-impact cleanup and upkeep
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants