updates to VersionPlace for less code-reusage downstream #952
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dev-mlb
requested changes
Sep 25, 2024
dev-mlb
approved these changes
Sep 30, 2024
jpdahlke
added
enhancement
jpdahlke
approved these changes
Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basically gets rid of the use of
emissary.util.Version, and relies onGitRepositoryStateto get the version and hash. This allows for a lot less code-reusage for classes downstream that extend this.Created setters for the booleans so they can be set downstream.
One thing to keep in mind for this is the BuildTime is only reset in the
emissary.git.propertiesfile when "mvn clean" is run