Dockerfile and docker compose updates #965
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dev-mlb
previously approved these changes
Oct 7, 2024
jpdahlke
added
CI/CD
jpdahlke
reviewed
Oct 11, 2024
thx for catching that Co-authored-by: jpdahlke <[email protected]>
jpdahlke
reviewed
Oct 11, 2024
good catch Co-authored-by: jpdahlke <[email protected]>
dev-mlb
approved these changes
Oct 11, 2024
|
I'm having trouble with the UID:GID entries in the compose files. If I remove them everything starts up like I would expect. I'm not sure if I built something wrong or if I have an env issue, but if that's not hindering others then I won't hold this up to figure out why. |
jpdahlke
approved these changes
Oct 11, 2024
|
The only way I got it to work was to add the UID:GID. It was not there originally. I am on linux, I think the issue was OS based. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dockerfile now has all docker flavors (ubi8 (default), centos7 and alpine)
Unnecessary Dockerfiles have been removed
docker compose files have been updated to support single emissary server and cluster option
To test:
Run through the docker steps in DEVELOPING.md starting at line 596
Make sure you can build a docker
Run emissary docker and process a file
Run docker compose for single emissary server and process file
Run docker compose for emissary cluster and process file